Refactor the sockets_utils.h headers#729
Open
alexcrichton wants to merge 1 commit intoWebAssembly:mainfrom
Open
Refactor the sockets_utils.h headers#729alexcrichton wants to merge 1 commit intoWebAssembly:mainfrom
sockets_utils.h headers#729alexcrichton wants to merge 1 commit intoWebAssembly:mainfrom
Conversation
This commit refactors the helpers for TCP/UDP which predated much of the work around WASIp2-natively-in-libc. Changes here are: * Helpers to use `__wasilibc_*` prefix that many other internal functions in wasi-libc use. * Helpers directly set `errno` instead of returning a `bool` and requiring the caller to set `errno`. * Some helpers were renamed/tweaked to be a bit more idiomatic with C.
alexcrichton
force-pushed
the
refactor-socket-utis
branch
from
1b0e407 to
192172f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit refactors the helpers for TCP/UDP which predated much of the work around WASIp2-natively-in-libc. Changes here are:
__wasilibc_*prefix that many other internal functions in wasi-libc use.errnoinstead of returning abooland requiring the caller to seterrno.