Skip to content

Update some features#346

Merged
dschuff merged 2 commits intoWebAssembly:mainfrom
CryZe:patch-2
Sep 25, 2023
Merged

Update some features#346
dschuff merged 2 commits intoWebAssembly:mainfrom
CryZe:patch-2

Conversation

@CryZe
Copy link
Contributor

@CryZe CryZe commented Sep 24, 2023

Chrome, wasmtime and wasmer were a little outdated / inaccurate.

Chrome, wasmtime and wasmer were a little outdated / inaccurate.
"saturatedFloatToInt": true,
"signExtensions": true,
"simd": "2.0",
"threads": null,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if it's accurate that they don't have threads support, but it's at least more accurate than saying that threads support is not applicable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this was semi intentional considering there was no way to spawn threads (#313 (comment)), but this isn't the case anymore. There's a Rust target wasm32-wasi-preview1-threads that supports spawning threads and wasmtime supports it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, if there's now a way to spawn and use threads in these runtimes, I think it makes sense to mark this as supported. The exact mechanism for that (web workers, a WASI or even a nonstandard interface) is outside the scope of the core spec, and probably outside the scope of this page as it's currently designed. It might be helpful to find a way to link to some information (maybe just as an annotation alongside our long list of flags or something) but I think what you have proposed here is still an improvement over the current version. (and I think I'd accept a PR marking threads as supported behind a flag or whatever).

Runtimes that don't target JavaScript don't need to support JSPI.
"saturatedFloatToInt": true,
"signExtensions": true,
"simd": "2.0",
"threads": null,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, if there's now a way to spawn and use threads in these runtimes, I think it makes sense to mark this as supported. The exact mechanism for that (web workers, a WASI or even a nonstandard interface) is outside the scope of the core spec, and probably outside the scope of this page as it's currently designed. It might be helpful to find a way to link to some information (maybe just as an annotation alongside our long list of flags or something) but I think what you have proposed here is still an improvement over the current version. (and I think I'd accept a PR marking threads as supported behind a flag or whatever).

@dschuff
Copy link
Member

dschuff commented Sep 25, 2023

I'll go ahead and merge this, we can iterate more on how to handle threads if there is interest.

@dschuff dschuff merged commit 2319143 into WebAssembly:main Sep 25, 2023
@CryZe CryZe deleted the patch-2 branch September 25, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants