Skip to content

Update some features #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dschuff merged 2 commits into from
Sep 25, 2023
Merged

Update some features #346

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05a445a
Update some features
CryZe Sep 24, 2023
23cf205
JSPI isn't applicable to native runtimes
CryZe Sep 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions features.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@
"multiMemory": ["flag", "Requires flag `chrome://flags/#enable-experimental-webassembly-features`"],
"multiValue": "85",
"mutableGlobals": "74",
"relaxedSimd": ["flag", "Requires flag `chrome://flags/#enable-experimental-webassembly-features`"],
"relaxedSimd": "114",
"referenceTypes": "96",
"saturatedFloatToInt": "75",
"signExtensions": "74",
Expand Down Expand Up @@ -163,16 +163,18 @@
"features": {
"bigInt": null,
"bulkMemory": "0.20",
"jspi": null,
"memory64": ["flag", "Requires flag `--wasm-features=memory64`"],
"multiMemory": ["flag", "Requires flag `--wasm-features=multi-memory`"],
"multiValue": "0.17",
"mutableGlobals": true,
"referenceTypes": "0.20",
"relaxedSimd": ["flag", "Requires flag `--wasm-features=relaxed-simd`"],
"saturatedFloatToInt": true,
"signExtensions": true,
"simd": "0.33",
"tailCall": ["flag", "Requires flag `--wasm-features=tail-call`"],
"threads": null
"threads": ["flag", "Requires flag `--wasm-features=threads`"]
}
},
"Wasmer": {
Expand All @@ -181,13 +183,13 @@
"features": {
"bigInt": null,
"bulkMemory": "1.0",
"jspi": null,
"multiValue": "1.0",
"mutableGlobals": "0.7",
"referenceTypes": "2.0",
"saturatedFloatToInt": true,
"signExtensions": true,
"simd": "2.0",
"threads": null,
Copy link
Contributor Author

@CryZe CryZe Sep 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if it's accurate that they don't have threads support, but it's at least more accurate than saying that threads support is not applicable.

Copy link
Contributor Author

@CryZe CryZe Sep 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this was semi intentional considering there was no way to spawn threads (#313 (comment)), but this isn't the case anymore. There's a Rust target wasm32-wasi-preview1-threads that supports spawning threads and wasmtime supports it.

Copy link
Member

@dschuff dschuff Sep 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, if there's now a way to spawn and use threads in these runtimes, I think it makes sense to mark this as supported. The exact mechanism for that (web workers, a WASI or even a nonstandard interface) is outside the scope of the core spec, and probably outside the scope of this page as it's currently designed. It might be helpful to find a way to link to some information (maybe just as an annotation alongside our long list of flags or something) but I think what you have proposed here is still an improvement over the current version. (and I think I'd accept a PR marking threads as supported behind a flag or whatever).

"typeReflection": "2.0"
}
},
Expand Down Expand Up @@ -243,6 +245,7 @@
"bulkMemory": "1.0.30",
"exceptions": ["flag", "Requires flag `--enable-exceptions`"],
"extendedConst": ["flag", "Requires flag `--enable-extended-const`"],
"jspi": null,
"memory64": ["flag", "Requires flag `--enable-memory64`"],
"multiMemory": ["flag", "Requires flag `--enable-multi-memory`"],
"multiValue": "1.0.24",
Expand Down