UI: Add Fieldset primitives
#74296
Open
UI: Add Fieldset primitives
#74296
+413
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 2.59 MB ℹ️ View Unchanged
|
Member
|
Regarding the included example, I wonder if the discussion at #63734 would be relevant to how we'd want to organize the subcomponents (i.e. description first)? The nice thing about the modularity is that consumers would have the choice to rearrange the content, but the documented example would be the recommended starting point. |
aduth
approved these changes
Jan 2, 2026
Comment on lines
+5
to
+7
| display: flex; | ||
| flex-direction: column; | ||
| gap: var(--wpds-dimension-gap-2xs); |
Member
There was a problem hiding this comment.
Should it use Stack ? I guess this is a similar discussion to #73931 (comment) as far as how much we lean on CSS and tolerance for HTML element nesting vs. flattening 🙃
aduth
reviewed
Jan 2, 2026
| @@ -0,0 +1,67 @@ | |||
| import type { Meta, StoryObj } from '@storybook/react'; | |||
Member
There was a problem hiding this comment.
With changes in #74317, does this need to be... ?
Suggested change
| import type { Meta, StoryObj } from '@storybook/react'; | |
| import type { Meta, StoryObj } from '@storybook/react-webpack5'; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #74178
What?
Add
Fieldsetprimitive components to@wordpress/ui.Why?
These adopt the same label/description styles used in
BaseControlin@wordpress/components(andFieldin@wordpress/ui), but providefieldsetsemantics instead. They are modular from the outset, and based on Base UI.How?
A context-based
Descriptionsubcomponent is added by us to the Base UI components. This will be necessary in things like ourRadioControlreplacement, which has a description for the entire group.Testing Instructions
See stories in Storybook.
Screenshots or screencast