Update eslint-plugin-storybook to 10.1.11 #74317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
github-actions
bot
added
[Package] Components
|
Size Change: 0 B Total Size: 2.59 MB ℹ️ View Unchanged
|
mirka
requested review from
a team and
manzoorwanijk
and removed request for
a team,
ajitbohra,
gigitux,
ntsekouras and
oandregal
|
Flaky tests detected in 214cb46. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/20642954843
|
manzoorwanijk
approved these changes
Jan 1, 2026
Member
manzoorwanijk
left a comment
manzoorwanijk
left a comment
There was a problem hiding this comment.
I initially did it but then reverted to reduce the number of changes in my PR. Thank you for the follow up.
mirka
requested review from
gziolo,
nerrad,
ntwb and
ryanwelcher
as code owners
This was referenced Jan 2, 2026
Contributor
|
Since this PR, my ESLint extension plugin no longer works in my code editor (Cursor) and outputs the following error: 
Perhaps it's related to the fact that Storybook 10 now only supports ESM? In fact, if I downgrade |
Member
This happens because you can't |
Member
Proposing this in #74342. |
Contributor
|
@jsnajdr Thanks for the information.
Unfortunately, this didn't work for me, possibly because I'm using Volta. Instead, I was able to solve the problem by writing the following settings to {
"eslint.runtime": "/path/to/.volta/tools/image/node/22.21.1/bin/node"
} |
Member
It seems to be fine on lates trunk - 6c90b9e |
ciampo
pushed a commit
that referenced
this pull request
Jan 7, 2026
* Update eslint-plugin-storybook to 10.1.11 * Re-enable lint rule * Change everything to `@storybook/react-webpack5` * Clean up unnecessary deps Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: manzoorwanijk <manzoorwanijk@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Stacked on #74316
Follow-up to #74143
Updates
eslint-plugin-storybookto the latest 10.1.11.Why?
To better match usage of newer Storybook versions.
The new plugin adds lint rules for renderer packages, so they are fixed here as well:
Testing Instructions
Lint check passes.