Add admin tools page#77
Conversation
felixarntz
left a comment
felixarntz
left a comment
There was a problem hiding this comment.
@vishalkakadiya Mostly looks good. A few small things to iterate on.
|
@felixarntz I have addressed your feedback. Thank you! |
felixarntz
left a comment
felixarntz
left a comment
There was a problem hiding this comment.
@vishalkakadiya A few last bits of feedback here, but looks almost good to go now.
|
@felixarntz I have addressed the last feedback. Thanks! |
felixarntz
left a comment
felixarntz
left a comment
There was a problem hiding this comment.
@vishalkakadiya Thanks, LGTM!
joemcgill
left a comment
joemcgill
left a comment
There was a problem hiding this comment.
This looks pretty good to me besides one suggestion about how we're unit testing the render callback for the admin page.
jjgrainger
left a comment
jjgrainger
left a comment
There was a problem hiding this comment.
Thanks @vishalkakadiya looks good!
felixarntz
left a comment
felixarntz
left a comment
There was a problem hiding this comment.
@vishalkakadiya While addressing @joemcgill's feedback, can you please also add the missing @since annotations?
|
Thanks @felixarntz @joemcgill as the PR has 2 approvals and the remaining feedback has been addressed I'll merge this PR. |
4 participants
Add admin tools page
Closes #32