Add 'check this plugin' link on the plugin list table#89
Merged
Conversation
Author
|
@felixarntz @jjgrainger I have raised the PR for the #36, but this PR depends upon the #77 to be merged, thank you! |
vishalkakadiya
changed the base branch from
trunk
to
feature/add-admin-tools-page
felixarntz
reviewed
Feb 23, 2023
Member
felixarntz
left a comment
felixarntz
left a comment
There was a problem hiding this comment.
@vishalkakadiya Almost LGTM, just a few small things here.
Of course we still need to merge #77 first.
added 2 commits
February 24, 2023 18:27
Author
|
@felixarntz I have addressed all your feedback. Thank you! |
jjgrainger
approved these changes
Feb 24, 2023
Contributor
jjgrainger
left a comment
jjgrainger
left a comment
There was a problem hiding this comment.
Thanks @vishalkakadiya looks good!
felixarntz
reviewed
Feb 24, 2023
Member
felixarntz
left a comment
felixarntz
left a comment
There was a problem hiding this comment.
@vishalkakadiya LGTM! Just a few nit-picks, but I approved this already..
Author
|
@felixarntz I have addressed the feedback on it. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add 'check this plugin' link on the plugin list table
Closes #36