Add support for the IncludeOnline parameter in Attachment saving #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for this. Reviewing the changes now. I think it's probably more appropriate to start an I'll update as I need to change some tests anyway. |
Contributor
|
Merged in PR #46. Note i've changed the format to be an options object instead. Please check the docs for the correct formatting. Thanks for the contribution. |
Contributor
|
xero-node@2.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was no observed way to utilise the parameter IncludeOnline when saving an attachment to an invoice, nor any way for the existing Save method to collect a value for it. As such, I've added a parameter to the save function that defaults to false (including when undefined) which should maintain API compatibility. The Xero API defaults to false for this parameter, hence the part in putOrPost only sets it if true.