Fix exclude_regex functionality (Issue 17)#45
Fix exclude_regex functionality (Issue 17)#45sp3nx0r wants to merge 7 commits intoYelp:masterfrom sp3nx0r:exclude_regex_fix
Conversation
|
Thanks so much for making this! 🙏 I will take a look at it this weekend |
|
(Gonna review after Tavis passes self.add_non_local_repo(mock_rootdir)
> assert not mock_file_operations.write.called
E AssertionError: assert not True
E + where True = <MagicMock name='open().write' id='139948498142936'>.called
E + where <MagicMock name='open().write' id='139948498142936'> = <MagicMock name='open()' id='139948498142488'>.write
tests/actions/initialize_test.py:243: AssertionError
===================== 1 failed, 97 passed in 1.22 seconds ======================I think) |
Similar test case modification for the empty repo PR #46. Will open a new issue to handle overriding globally because maybe someone wants to not always override? |
KevinHock
left a comment
There was a problem hiding this comment.
lgtm 🚢 ![]()
Thanks so much for making this!
I think there is a merge conflict that needs to be resolve, but that's it.
|
Looks like this PR pushed us under 93% coverage in Travis:
|
Addresses #17 and #44
Removes
exclude_regexfrom tracked repo metadata and config yaml add and replaces with anexclude_files_regexandexclude_lines_regex. CLI args are appended to the repo args (but are not overwritten in tracked repo metadata).