Handle empty git repos #46
Merged
KevinHock merged 3 commits intoYelp:masterfrom Jan 28, 2020
sp3nx0r:empty_git_alt
Merged
Conversation
KevinHock
approved these changes
Jan 28, 2020
Collaborator
KevinHock
left a comment
There was a problem hiding this comment.
Looks really great to me, thank you for making this!
Asked for one clarification, but that's all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses Issue #19
Two changes:
scan.py. This also required a change in_clone_and_save_repo()to allow an update to existing metadata.Unintended side effect was having to change the test case for existing metadata. I flipped it to testing for allowing update because my mocking blows and I couldn't figure out how to easily add a
repo.last_commit_hashso it wouldn't take the empty repo path.