Conversation
Codecov Report
@@ Coverage Diff @@
## master #165 +/- ##
=========================================
Coverage ? 92.82%
=========================================
Files ? 70
Lines ? 641
Branches ? 166
=========================================
Hits ? 595
Misses ? 46
Partials ? 0
Continue to review full report at Codecov.
|
0ubbe
commented
Jan 15, 2020
0ubbe
commented
Jan 15, 2020
dfvalero
previously approved these changes
Jan 17, 2020
Contributor
Author
|
Seems that we need to teach Rollup how to read JSON as well: ( when running |
So that Rollup knows how to handle JSON file imports
3db4ba8 to
0caff36
Compare
steedems
approved these changes
Jan 17, 2020
Contributor
|
🎉 This PR is included in version 2.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Feb 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #164, get Tippy's CSS from a CDN rather than add it as part of our package.
This is to keep our build simple and passing without the need to make Rollup aware of how to handle CSS files 💆🏻♂️