Skip to content

Fix <Tooltip /> CSS 🔧#165

Merged
0ubbe merged 3 commits intomasterfrom
fix/tooltip-css-build
Jan 20, 2020
Merged

Fix <Tooltip /> CSS 🔧#165
0ubbe merged 3 commits intomasterfrom
fix/tooltip-css-build

Conversation

@0ubbe
Copy link
Copy Markdown
Contributor

@0ubbe 0ubbe commented Jan 15, 2020

Following #164, get Tippy's CSS from a CDN rather than add it as part of our package.

This is to keep our build simple and passing without the need to make Rollup aware of how to handle CSS files 💆🏻‍♂️

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 15, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@0caff36). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #165   +/-   ##
=========================================
  Coverage          ?   92.82%           
=========================================
  Files             ?       70           
  Lines             ?      641           
  Branches          ?      166           
=========================================
  Hits              ?      595           
  Misses            ?       46           
  Partials          ?        0
Impacted Files Coverage Δ
src/components/hooks/useForm/useForm.ts 100% <100%> (ø)
...c/components/organisms/Form/context/FormContext.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0caff36...25268ab. Read the comment docs.

dfvalero
dfvalero previously approved these changes Jan 17, 2020
@0ubbe
Copy link
Copy Markdown
Contributor Author

0ubbe commented Jan 17, 2020

Seems that we need to teach Rollup how to read JSON as well:

/Users/lluis.agusti/Code/zopa-react-components/src/index.ts → cjs, es...
[!] (plugin babel) SyntaxError: /Users/lluis.agusti/Code/zopa-react-components/node_modules/tippy.js/package.json: Unexpected token, expected
 ";" (2:8)

  1 | {
> 2 |   "name": "tippy.js",
    |         ^
  3 |   "version": "5.1.4",
  4 |   "description": "Highly customizable tooltip and popover library",
  5 |   "main": "dist/tippy.cjs.js",
node_modules/tippy.js/package.json (2:8)

( when running yarn compile 😪 , breaks due to this import )

So that Rollup knows how to handle JSON file imports
@0ubbe 0ubbe merged commit 675fc4a into master Jan 20, 2020
@0ubbe 0ubbe deleted the fix/tooltip-css-build branch January 20, 2020 10:44
@poteirard
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 2.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants