Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #246 +/- ##
==========================================
- Coverage 93% 92.71% -0.29%
==========================================
Files 69 70 +1
Lines 643 645 +2
Branches 124 180 +56
==========================================
Hits 598 598
- Misses 45 47 +2
Continue to review full report at Codecov.
|
Contributor
Author
|
I'm thinking to base this against |
af77019 to
432bd19
Compare
0ubbe
commented
Feb 27, 2020
poteirard
reviewed
Mar 2, 2020
Contributor
Author
|
I'm going to change a bit the approach on this PR 💭 I think I'll follow the same API as with |
432bd19 to
76f0f9e
Compare
poteirard
approved these changes
Mar 5, 2020
Contributor
|
🎉 This PR is included in version 2.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We were importing Tippy CSS through a CSS import on
<GlobalStyles />.@moshie and @endymion1818 fairly pointed out that it increased a bit the HTTP handshake on the consumers not using tooltips.
The main issue though is that
styled-components@5does not support anymore CSS@import.There's work planned on moving to just PopperJS.
Related
#165
#234
styled-components/styled-components#2995