Skip to content

Move Tippy CSS to our bundle 🧵#246

Merged
poteirard merged 4 commits intomasterfrom
fix/234-move-tippy-import
Mar 5, 2020
Merged

Move Tippy CSS to our bundle 🧵#246
poteirard merged 4 commits intomasterfrom
fix/234-move-tippy-import

Conversation

@0ubbe
Copy link
Copy Markdown
Contributor

@0ubbe 0ubbe commented Feb 27, 2020

Summary

We were importing Tippy CSS through a CSS import on <GlobalStyles />.

@moshie and @endymion1818 fairly pointed out that it increased a bit the HTTP handshake on the consumers not using tooltips.

The main issue though is that styled-components@5 does not support anymore CSS @import.

There's work planned on moving to just PopperJS.

Related

#165
#234

styled-components/styled-components#2995

@0ubbe 0ubbe changed the base branch from master to v3 February 27, 2020 17:33
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 27, 2020

Codecov Report

Merging #246 into master will decrease coverage by 0.28%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #246      +/-   ##
==========================================
- Coverage      93%   92.71%   -0.29%     
==========================================
  Files          69       70       +1     
  Lines         643      645       +2     
  Branches      124      180      +56     
==========================================
  Hits          598      598              
- Misses         45       47       +2
Impacted Files Coverage Δ
src/components/styles/GlobalStyles.tsx 100% <ø> (ø) ⬆️
.../molecules/Tooltip/TooltipStyles/TooltipStyles.tsx 100% <100%> (ø)
src/components/molecules/Tooltip/Tooltip.tsx 100% <100%> (ø) ⬆️
src/components/styles/Fonts.tsx 0% <0%> (-100%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdafe3b...213325b. Read the comment docs.

@0ubbe
Copy link
Copy Markdown
Contributor Author

0ubbe commented Feb 27, 2020

I'm thinking to base this against master instead given it could go out now 🤔

@0ubbe 0ubbe force-pushed the fix/234-move-tippy-import branch 2 times, most recently from af77019 to 432bd19 Compare February 27, 2020 17:50
@0ubbe 0ubbe changed the base branch from v3 to master February 27, 2020 17:51
@0ubbe 0ubbe changed the title Move Tippy CSS to our bundle 🧵 Move Tippy CSS to our bundle 🧵 [WIP] Feb 27, 2020
@0ubbe 0ubbe changed the title Move Tippy CSS to our bundle 🧵 [WIP] Move Tippy CSS to our bundle 🧵 Mar 2, 2020
@0ubbe
Copy link
Copy Markdown
Contributor Author

0ubbe commented Mar 2, 2020

I'm going to change a bit the approach on this PR 💭

I think I'll follow the same API as with <Modal.Styles /> and force clients to declare explicitly <Tooltip.Styles /> on their top-level component.

@0ubbe 0ubbe changed the title Move Tippy CSS to our bundle 🧵 [WIP] Move Tippy CSS to our bundle 🧵 Mar 2, 2020
@0ubbe 0ubbe changed the title [WIP] Move Tippy CSS to our bundle 🧵 Move Tippy CSS to our bundle 🧵 Mar 2, 2020
@0ubbe 0ubbe force-pushed the fix/234-move-tippy-import branch from 432bd19 to 76f0f9e Compare March 5, 2020 17:31
@poteirard poteirard merged commit 6531f20 into master Mar 5, 2020
@poteirard poteirard deleted the fix/234-move-tippy-import branch March 5, 2020 17:45
@poteirard
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 2.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants