use /usr/bin/env bash instead of /bin/bash#131
Merged
SamTebbs33 merged 1 commit intoZystemOS:developfrom Apr 14, 2020
Merged
Conversation
Collaborator
|
Thanks for spotting this. Would you mind force-pushing to the branch to re-launch the checks? They seem to be broken at the moment. |
SamTebbs33
approved these changes
Apr 13, 2020
Collaborator
|
I think you will need to enable GitHub actions in your fork for the checks to happen |
Contributor
Author
Collaborator
|
I believe that the problem lies in our workflow file and should be fixed by #132 . Once that is merged, the checks should be run once you reopen the PR. |
Contributor
Author
|
Looks like after I rebased to get #132 that fixed the issue. |
Collaborator
|
Brilliant, thanks for this :) |
Closed
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

!/usr/bin/env bashworks on more systems than!/bin/bash. I use NixOS which doesn't have/bin/bashand I know some BSDs also don't have/bin/bash.