Skip to content

use /usr/bin/env bash instead of /bin/bash#131

Merged
SamTebbs33 merged 1 commit intoZystemOS:developfrom
marler8997:shebang
Apr 14, 2020
Merged

use /usr/bin/env bash instead of /bin/bash#131
SamTebbs33 merged 1 commit intoZystemOS:developfrom
marler8997:shebang

Conversation

@marler8997
Copy link
Contributor

!/usr/bin/env bash works on more systems than !/bin/bash. I use NixOS which doesn't have /bin/bash and I know some BSDs also don't have /bin/bash.

@SamTebbs33
Copy link
Collaborator

Thanks for spotting this. Would you mind force-pushing to the branch to re-launch the checks? They seem to be broken at the moment.

@marler8997 marler8997 closed this Apr 13, 2020
@marler8997 marler8997 reopened this Apr 13, 2020
@SamTebbs33 SamTebbs33 self-requested a review April 13, 2020 20:19
@SamTebbs33
Copy link
Collaborator

I think you will need to enable GitHub actions in your fork for the checks to happen

@marler8997
Copy link
Contributor Author

It looks like actions are already enabled:
image

@SamTebbs33
Copy link
Collaborator

I believe that the problem lies in our workflow file and should be fixed by #132 . Once that is merged, the checks should be run once you reopen the PR.

@marler8997 marler8997 closed this Apr 14, 2020
@marler8997 marler8997 reopened this Apr 14, 2020
@marler8997
Copy link
Contributor Author

Looks like after I rebased to get #132 that fixed the issue.

@SamTebbs33 SamTebbs33 merged commit 8523bcf into ZystemOS:develop Apr 14, 2020
@SamTebbs33
Copy link
Collaborator

Brilliant, thanks for this :)

@marler8997 marler8997 deleted the shebang branch April 14, 2020 20:49
@SamTebbs33 SamTebbs33 mentioned this pull request Jul 12, 2020
@SamTebbs33 SamTebbs33 mentioned this pull request Jul 20, 2020
@SamTebbs33 SamTebbs33 mentioned this pull request Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants