[PUB-925] Add new protocol message flags, actions, channel modes and message types for Objects#279
Merged
VeskeR merged 2 commits intointegration/objectsfrom Apr 2, 2025
Conversation
VeskeR
force-pushed
the
PUB-925/objects-channel-changes
branch
from
a74f41f to
cac4111
Compare
VeskeR
force-pushed
the
PUB-925/objects-channel-changes
branch
from
cac4111 to
380eb38
Compare
VeskeR
force-pushed
the
PUB-925/objects-channel-changes
branch
from
380eb38 to
490b953
Compare
VeskeR
force-pushed
the
add-activate-action
branch
from
c5de3cc to
d44ca77
Compare
VeskeR
force-pushed
the
PUB-925/objects-channel-changes
branch
from
490b953 to
92b5a16
Compare
VeskeR
changed the title
VeskeR
changed the title
VeskeR
commented
Mar 13, 2025
VeskeR
commented
Mar 13, 2025
VeskeR
commented
Mar 13, 2025
SimonWoolf
approved these changes
Mar 14, 2025
Member
SimonWoolf
left a comment
SimonWoolf
left a comment
There was a problem hiding this comment.
I'm not super familiar with the state protocol, so just reviewing from the POV of well-formed-ness as a spec. From that POV this looks fine, nice job 👍. couple minor nitpicks.
mschristensen
requested changes
Mar 17, 2025
Contributor
mschristensen
left a comment
mschristensen
left a comment
There was a problem hiding this comment.
Suggested a couple of small changes & also echo Simon's comments, after that looks good
VeskeR
force-pushed
the
PUB-925/objects-channel-changes
branch
from
92b5a16 to
f79593c
Compare
VeskeR
force-pushed
the
PUB-925/objects-channel-changes
branch
from
f79593c to
74e2319
Compare
VeskeR
force-pushed
the
PUB-925/objects-channel-changes
branch
from
74e2319 to
7669d86
Compare
VeskeR
added a commit
to ably/ably-js
that referenced
this pull request
Mar 27, 2025
… feature This commit does next changes: - removes `state` mentions in comments / internal API. Uses `objects` instead where possible - `STATE` message action -> `OBJECT` - `STATE_SYNC` message action -> `OBJECT_SYNC` - `HAS_STATE` flag -> `HAS_OBJECT` - `StateMessage` type -> `ObjectMessage` - `StateOperation` type -> `ObjectOperation` - `StateObject` type -> `ObjectState` - `StateData` type -> `ObjectData` - `StateValue` type -> `ObjectValue` This brings ably-js LiveObjects implementation in line with the naming changes introduced in the spec PR [1]. [1] ably/specification#279 (comment)
VeskeR
added a commit
to ably/ably-js
that referenced
this pull request
Mar 27, 2025
… feature This commit does next changes: - removes `state` mentions in comments / internal API. Uses `objects` instead where possible - normalizes terminology used when referencing "LiveObjects" product and objects on a channel according to LiveObjects product docs PR [1] - `STATE` message action -> `OBJECT` - `STATE_SYNC` message action -> `OBJECT_SYNC` - `HAS_STATE` flag -> `HAS_OBJECT` - `StateMessage` type -> `ObjectMessage` - `StateOperation` type -> `ObjectOperation` - `StateObject` type -> `ObjectState` - `StateData` type -> `ObjectData` - `StateValue` type -> `ObjectValue` This brings ably-js LiveObjects implementation in line with the naming changes introduced in the spec PR [2]. [1] ably/docs#2463 (review) [2] ably/specification#279 (comment)
VeskeR
added a commit
to ably/ably-js
that referenced
this pull request
Mar 27, 2025
… / site codes in client side LiveObjects implementation See the relevant discussion in the spec PR [1] [1] ably/specification#279 (comment)
lawrence-forooghian
approved these changes
Mar 27, 2025
VeskeR
added a commit
to ably/ably-js
that referenced
this pull request
Mar 31, 2025
… / site codes in client side LiveObjects implementation See the relevant discussion in the spec PR [1] [1] ably/specification#279 (comment)
VeskeR
added a commit
to ably/ably-js
that referenced
this pull request
Apr 1, 2025
… feature This commit does next changes: - removes `state` mentions in comments / internal API. Uses `objects` instead where possible - normalizes terminology used when referencing "LiveObjects" product and objects on a channel according to LiveObjects product docs PR [1] - `STATE` message action -> `OBJECT` - `STATE_SYNC` message action -> `OBJECT_SYNC` - `HAS_STATE` flag -> `HAS_OBJECT` - `StateMessage` type -> `ObjectMessage` - `StateOperation` type -> `ObjectOperation` - `StateObject` type -> `ObjectState` - `StateData` type -> `ObjectData` - `StateValue` type -> `ObjectValue` This brings ably-js LiveObjects implementation in line with the naming changes introduced in the spec PR [2]. [1] ably/docs#2463 (review) [2] ably/specification#279 (comment)
VeskeR
added a commit
to ably/ably-js
that referenced
this pull request
Apr 1, 2025
… / site codes in client side LiveObjects implementation See the relevant discussion in the spec PR [1] [1] ably/specification#279 (comment)
… and ChannelMetrics for Objects Resolves PUB-925
VeskeR
force-pushed
the
PUB-925/objects-channel-changes
branch
from
3ec3f47 to
139c972
Compare
Contributor
Author
|
Renamed |
VeskeR
added a commit
to ably/ably-js
that referenced
this pull request
Apr 9, 2025
… feature This commit does next changes: - removes `state` mentions in comments / internal API. Uses `objects` instead where possible - normalizes terminology used when referencing "LiveObjects" product and objects on a channel according to LiveObjects product docs PR [1] - `STATE` message action -> `OBJECT` - `STATE_SYNC` message action -> `OBJECT_SYNC` - `HAS_STATE` flag -> `HAS_OBJECT` - `StateMessage` type -> `ObjectMessage` - `StateOperation` type -> `ObjectOperation` - `StateObject` type -> `ObjectState` - `StateData` type -> `ObjectData` - `StateValue` type -> `ObjectValue` This brings ably-js LiveObjects implementation in line with the naming changes introduced in the spec PR [2]. [1] ably/docs#2463 (review) [2] ably/specification#279 (comment)
VeskeR
added a commit
to ably/ably-js
that referenced
this pull request
Apr 9, 2025
… / site codes in client side LiveObjects implementation See the relevant discussion in the spec PR [1] [1] ably/specification#279 (comment)
VeskeR
added a commit
to ably/ably-js
that referenced
this pull request
Apr 9, 2025
… feature This commit does next changes: - removes `state` mentions in comments / internal API. Uses `objects` instead where possible - normalizes terminology used when referencing "LiveObjects" product and objects on a channel according to LiveObjects product docs PR [1] - `STATE` message action -> `OBJECT` - `STATE_SYNC` message action -> `OBJECT_SYNC` - `HAS_STATE` flag -> `HAS_OBJECT` - `StateMessage` type -> `ObjectMessage` - `StateOperation` type -> `ObjectOperation` - `StateObject` type -> `ObjectState` - `StateData` type -> `ObjectData` - `StateValue` type -> `ObjectValue` This brings ably-js LiveObjects implementation in line with the naming changes introduced in the spec PR [2]. [1] ably/docs#2463 (review) [2] ably/specification#279 (comment)
VeskeR
added a commit
to ably/ably-js
that referenced
this pull request
Apr 9, 2025
… / site codes in client side LiveObjects implementation See the relevant discussion in the spec PR [1] [1] ably/specification#279 (comment)
VeskeR
added a commit
to ably/ably-js
that referenced
this pull request
Apr 9, 2025
… feature This commit does next changes: - removes `state` mentions in comments / internal API. Uses `objects` instead where possible - normalizes terminology used when referencing "LiveObjects" product and objects on a channel according to LiveObjects product docs PR [1] - `STATE` message action -> `OBJECT` - `STATE_SYNC` message action -> `OBJECT_SYNC` - `HAS_STATE` flag -> `HAS_OBJECT` - `StateMessage` type -> `ObjectMessage` - `StateOperation` type -> `ObjectOperation` - `StateObject` type -> `ObjectState` - `StateData` type -> `ObjectData` - `StateValue` type -> `ObjectValue` This brings ably-js LiveObjects implementation in line with the naming changes introduced in the spec PR [2]. [1] ably/docs#2463 (review) [2] ably/specification#279 (comment)
VeskeR
added a commit
to ably/ably-js
that referenced
this pull request
Apr 9, 2025
… / site codes in client side LiveObjects implementation See the relevant discussion in the spec PR [1] [1] ably/specification#279 (comment)
VeskeR
added a commit
to ably/ably-js
that referenced
this pull request
May 8, 2025
See Simon's comment [1]. The `channel` property should not be expected in the wire protocol for object messages, just like it isn't present in a message or presencemessage. [1] ably/specification#279 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves PUB-925