Conversation
VeskeR
force-pushed
the
add-activate-action
branch
from
c5de3cc to
d44ca77
Compare
VeskeR
changed the title
ACTIVATE ProtocolMessage Action
Member
it's deprecated, no-one should be implementing it now, so no reason to document. (it existed just to support ably-js transport upgrading, before v2 removed transport upgrading). I recommend "(reserved for a deprecated use)" or something |
VeskeR
force-pushed
the
add-activate-action
branch
from
d44ca77 to
30bb437
Compare
VeskeR
force-pushed
the
add-activate-action
branch
from
30bb437 to
c96efc9
Compare
mschristensen
approved these changes
Mar 24, 2025
VeskeR
force-pushed
the
add-activate-action
branch
from
c96efc9 to
436309e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TR2 reads as follows:
and then lists the enums values.
My intention is to preserve the wording of the TR2 and just add the new actions for LiveObjects:
STATEandSTATE_SYNC(#279).And in order to do that, we need to first add the
ACTIVATEaction that is currently missing. Realtime enum: https://github.com/ably/realtime/blob/2fcbe71939df11794e31b29536accf076acdabec/protocol/common.proto#L139, and also added to ably-js even though not part of the spec: https://github.com/ably/ably-js/blob/a7d8181d62fcb2375cdaef3e86eb61c2fa349070/src/common/lib/types/protocolmessagecommon.ts#L23@SimonWoolf @mschristensen Could you please briefly describe the
ACTIVATEaction so I can write a description for it for the protocol page?