add from_versions in VersionRange
#55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks @keshav-space , this looks good to me, @pombredanne should we shift this to the VersionRange class so other sub classes can also use this functionality, to form ranges from sequences ? |
pombredanne
reviewed
Mar 28, 2022
TG1999
reviewed
Mar 28, 2022
keshav-space
changed the title
from_sequence in OpensslVersionRangefrom_versions in VersionRange
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
see: psf/black#2964 Signed-off-by: Keshav Priyadarshi <git@keshav.space>
TG1999
pushed a commit
to TG1999/univers
that referenced
this pull request
May 10, 2022
…_spaces_on_windows Configure for path with spaces on windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context: aboutcode-org/vulnerablecode#648 (comment)
Signed-off-by: Keshav Priyadarshi git@keshav.space