Migrate openssl importer to importer-improver model #648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TG1999
reviewed
Mar 21, 2022
TG1999
requested changes
Mar 21, 2022
Contributor
TG1999
left a comment
TG1999
left a comment
There was a problem hiding this comment.
Thanks for your contribution, please check my comments
keshav-space
commented
Mar 21, 2022
pombredanne
reviewed
Mar 21, 2022
TG1999
reviewed
Mar 22, 2022
pombredanne
requested changes
Mar 24, 2022
Member
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
Thanks! See some feedback below for your kind consideration.
Hritik14
requested changes
Apr 4, 2022
Collaborator
Hritik14
left a comment
Hritik14
left a comment
There was a problem hiding this comment.
@keshav-space Thank you for the updates!! Please consider the following suggestions. Further, we're gonna need as many tests as possible.
pombredanne
requested changes
Apr 5, 2022
Member
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
Thank for the updates...we are almost there! just a few nit pickings left.
pombredanne
requested changes
Apr 8, 2022
pombredanne
requested changes
Apr 8, 2022
Member
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
Do you mind to squash and amend your commits to have a cleaner stream of commit messages?
pombredanne
requested changes
Apr 9, 2022
Member
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
We are almost there... See a few last nitpickings for your consideration before we merge
Member
|
I merged some other code... so you have some merge conflicts to resolve now |
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Migrate github importer to importer-improver model Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Work around PostgreSQL index issue Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>
Same about importer Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
This can cause endless, infinite loop of failure/restart Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Ensure that we always install "dot" locally Streamline other target Remove unused targets Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
* Format long lines in doctests. * Remove dead imports. * Convert comments to docstring Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
* Use setup.cfg rather than setup.py * Use new [dev] extra for development utilities * Use requirements.txt as constraints for pinning deps. Drop using requirements-dev.txt * Update pyproject.toml for tools including pytest, black and isort * Update Makefile and Dockerfile accordingly * Bump version to signal this is a beta * Update dockerignore and other confif files * Bump dependencies Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
This is too complex and requires more design to enable. Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
There is a precedence of /etc/vulnerablecode/.env over the local .env file in all cases Reported-by: Hritik Vijay <hritikxx8@gmail.com> Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Member
|
Sounds like you are leaning git ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #615
Signed-off-by: Keshav Priyadarshi git@keshav.space