UWP doesn't allow reading regkeys by LoadLibrary · Pull Request #594 · abseil/abseil-cpp

LoadLibrary · 2020-01-13T21:41:01Z

UWP doesn't allow reading regkeys. Unfortunately, UWP also doesn't offer an API for returning nominal processor frequency at this moment. Other options would require apps depending on abseil-cpp to be packaged with extra manifest data or libraries for bridging platforms.

This change pushes the unsupported APIs accessing the registry behind a define guard. This define guard makes GetNominalCPUFrequency to compile and run as usual on desktop, but it will return the value 1.0 on UWP Apps (Store).

Fixes: #593

googlebot · 2020-01-13T21:41:06Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

Unfortunately, UWP also doesn't offer an API for returning nominal processor frequency at this moment. Other options would require apps depending on abseil-cpp to be packaged with extra manifest data or libraries for bridging platforms. This change pushes the unsupported APIs accessing the registry behind a define guard. This define guard makes GetNominalCPUFrequency to compile and run as usual on desktop, but it will return the value 1.0 on UWP Apps (Store).

googlebot · 2020-01-13T22:31:46Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

absl/base/internal/sysinfo.cc

…lding for UWP or Desktop.

absl/base/internal/sysinfo.cc

zhangxy988 · 2020-01-23T16:18:41Z

I will run this through our internal testing system.

absl/base/internal/sysinfo.cc

JackBoosY · 2020-03-04T08:25:59Z

Hi guys, I have another issue:
In SOURCE/absl/debugging/symbolize_win32.inc function InitializeSymbolizer and Symbolize, there are functions SymSetOptions and SymFromAddr which are not supported under uwp[1][2].
So I simply disabled them: return directly or return false[3].
Is this acceptable?

[1]. https://docs.microsoft.com/en-us/windows/win32/api/dbghelp/nf-dbghelp-symfromaddr
[2]. DbgHelp.h Line 30:

#if WINAPI_FAMILY_PARTITION(WINAPI_PARTITION_DESKTOP | WINAPI_PARTITION_PKG_WER)

[3]. #10301

LoadLibrary · 2020-03-05T22:25:52Z

@JackBoosY The purpose of this PR is to fix the abseil build used by WebRTC for UWP. WINAPI_PARTITION_PKG_WER is not the right way to gate code based on UWP/Desktop partitions. Feel free to file another bug and post a different PR to fix SOURCE/absl/debugging/symbolize_win32.inc.

JackBoosY · 2020-03-06T04:23:36Z

@LoadLibrary Okay, but I'm not sure my changes is correct.

-- 2c5c118f0615ba90e48ee2f18eccc9f511740f6d by Samuel Benzaquen <sbenza@google.com>: Rename internal macros to follow the convention in absl. PiperOrigin-RevId: 299906738 -- 92d84a707c7ebc4ec19bdd92d5765d1b6d218c1e by Derek Mauro <dmauro@google.com>: Import GitHub #629: Skip the .exe suffix in the helpshort filter on Windows PiperOrigin-RevId: 299892396 -- 2a6910d4be6c67a8376628764121b528ff53504d by Abseil Team <absl-team@google.com>: Use unsigned int128 intrinsic when available. It generates better branchless code. PiperOrigin-RevId: 299848585 -- 110c16cf0a739e1df5028fb6fbd03ef5dde1d278 by Derek Mauro <dmauro@google.com>: Import GitHub #594: Avoid reading the registry for Windows UWP apps PiperOrigin-RevId: 299821671 -- d8397d367e88163e5e8a47f379c716352dc91d03 by Greg Falcon <gfalcon@google.com>: Add absl::Hash support for Cord. The hash function is heterogeneous with other string types: a Cord and a string with the same byte sequence will hash to the same value. SwissTable types know about Cord, and will allow heterogeneous lookup (e.g., you can pass a Cord to flat_hash_map<string, T>::find(), and vice versa.) Add a missing dependency to the cmake Cord target. PiperOrigin-RevId: 299443713 GitOrigin-RevId: 2c5c118f0615ba90e48ee2f18eccc9f511740f6d Change-Id: I7b087c7984b0cb52c4b337d49266c467b98ebdf9

* UWP doesn't allow reading regkeys. Unfortunately, UWP also doesn't offer an API for returning nominal processor frequency at this moment. Other options would require apps depending on abseil-cpp to be packaged with extra manifest data or libraries for bridging platforms. This change pushes the unsupported APIs accessing the registry behind a define guard. This define guard makes GetNominalCPUFrequency to compile and run as usual on desktop, but it will return the value 1.0 on UWP Apps (Store). * Using WINAPI_FAMILY_PARTITION family of macros for detecting when building for UWP or Desktop. * Simplifying comment to please the lint tool.

-- 2c5c118f0615ba90e48ee2f18eccc9f511740f6d by Samuel Benzaquen <sbenza@google.com>: Rename internal macros to follow the convention in absl. PiperOrigin-RevId: 299906738 -- 92d84a707c7ebc4ec19bdd92d5765d1b6d218c1e by Derek Mauro <dmauro@google.com>: Import GitHub abseil#629: Skip the .exe suffix in the helpshort filter on Windows PiperOrigin-RevId: 299892396 -- 2a6910d4be6c67a8376628764121b528ff53504d by Abseil Team <absl-team@google.com>: Use unsigned int128 intrinsic when available. It generates better branchless code. PiperOrigin-RevId: 299848585 -- 110c16cf0a739e1df5028fb6fbd03ef5dde1d278 by Derek Mauro <dmauro@google.com>: Import GitHub abseil#594: Avoid reading the registry for Windows UWP apps PiperOrigin-RevId: 299821671 -- d8397d367e88163e5e8a47f379c716352dc91d03 by Greg Falcon <gfalcon@google.com>: Add absl::Hash support for Cord. The hash function is heterogeneous with other string types: a Cord and a string with the same byte sequence will hash to the same value. SwissTable types know about Cord, and will allow heterogeneous lookup (e.g., you can pass a Cord to flat_hash_map<string, T>::find(), and vice versa.) Add a missing dependency to the cmake Cord target. PiperOrigin-RevId: 299443713 GitOrigin-RevId: 2c5c118f0615ba90e48ee2f18eccc9f511740f6d Change-Id: I7b087c7984b0cb52c4b337d49266c467b98ebdf9

googlebot added the cla: no label Jan 13, 2020

LoadLibrary changed the title ~~UWP doesn't allow reading regkeys. Unfortunately, UWP also doesn't of…~~ UWP doesn't allow reading regkeys Jan 13, 2020

googlebot added cla: yes and removed cla: no labels Jan 13, 2020

vslashg reviewed Jan 14, 2020

View reviewed changes

absl/base/internal/sysinfo.cc Outdated Show resolved Hide resolved

vslashg self-assigned this Jan 15, 2020

Using WINAPI_FAMILY_PARTITION family of macros for detecting when bui…

1690c6c

…lding for UWP or Desktop.

zhangxy988 added the kokoro:run label Jan 23, 2020

kokoro-team removed the kokoro:run label Jan 23, 2020

zhangxy988 reviewed Jan 23, 2020

View reviewed changes

absl/base/internal/sysinfo.cc Show resolved Hide resolved

zhangxy988 reviewed Jan 23, 2020

View reviewed changes

absl/base/internal/sysinfo.cc Outdated Show resolved Hide resolved

Simplifying comment to please the lint tool.

16cebbe

LoadLibrary requested review from vslashg and zhangxy988 February 7, 2020 16:51

JackBoosY mentioned this pull request Mar 4, 2020

[abseil] Add uwp support microsoft/vcpkg#10301

Merged

derekmauro merged commit 417ea99 into abseil:master Mar 9, 2020

LoadLibrary deleted the NoRegistryOnUWPs branch March 9, 2020 16:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UWP doesn't allow reading regkeys#594

UWP doesn't allow reading regkeys#594
derekmauro merged 3 commits intoabseil:masterfrom
LoadLibrary:NoRegistryOnUWPs

LoadLibrary commented Jan 13, 2020 •

edited

Loading

Uh oh!

googlebot commented Jan 13, 2020

Uh oh!

googlebot commented Jan 13, 2020

Uh oh!

Uh oh!

Uh oh!

zhangxy988 commented Jan 23, 2020

Uh oh!

Uh oh!

JackBoosY commented Mar 4, 2020

Uh oh!

LoadLibrary commented Mar 5, 2020 •

edited

Loading

Uh oh!

JackBoosY commented Mar 6, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

LoadLibrary commented Jan 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

googlebot commented Jan 13, 2020

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

googlebot commented Jan 13, 2020

Uh oh!

Uh oh!

Uh oh!

zhangxy988 commented Jan 23, 2020

Uh oh!

Uh oh!

JackBoosY commented Mar 4, 2020

Uh oh!

LoadLibrary commented Mar 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JackBoosY commented Mar 6, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

LoadLibrary commented Jan 13, 2020 •

edited

Loading

LoadLibrary commented Mar 5, 2020 •

edited

Loading