Skip to content

[abseil] Add uwp support#10301

Merged
strega-nil merged 5 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/abseil_add_uwp_support
Mar 6, 2020
Merged

[abseil] Add uwp support#10301
strega-nil merged 5 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/abseil_add_uwp_support

Conversation

@JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Mar 4, 2020

Use #594 changes and add some other changes to fix uwp support.

Since upstream fixed the usage error, removed patch fix-usage-lnk-error.patch and tested successfully.

Related: #10254 #9971.

This port doesn't contain any features.

@JackBoosY JackBoosY marked this pull request as ready for review March 4, 2020 08:01
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PhoebeHui
Copy link
Contributor

@strega-nil, could you help review?

@JackBoosY
Copy link
Contributor Author

JackBoosY commented Mar 4, 2020

grpc will update to 1.27.3 in #10242, but abseil became an optional dependency in the pre2-release version. only the function synchronization module of abseil will be an optional function of grpc[1], and the core of abseil still needs to be a required dependency of grpc.

So, when grpc is updated to the next official release, I will add feature abseil-sync to grpc in another update PR(#10307).

@strega-nil Could you please review this PR?

Thanks.

[1]. #21986

Copy link
Contributor

@strega-nil strega-nil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, but I'm confused about the one thing :)

@JackBoosY JackBoosY requested a review from strega-nil March 5, 2020 02:11
@strega-nil
Copy link
Contributor

Alright, awesome! Thanks so much @JackBoosY :)

@strega-nil
Copy link
Contributor

Alright, this looks good to me ! :D

@strega-nil strega-nil merged commit f9e78dc into microsoft:master Mar 6, 2020
@JackBoosY JackBoosY deleted the dev/jack/abseil_add_uwp_support branch March 6, 2020 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants