[abseil] Add uwp support#10301
Merged
strega-nil merged 5 commits intomicrosoft:masterfrom Mar 6, 2020
Merged
Conversation
Contributor
|
@strega-nil, could you help review? |
This was referenced Mar 4, 2020
Contributor
Author
|
So, when @strega-nil Could you please review this PR? Thanks. [1]. #21986 |
strega-nil
reviewed
Mar 4, 2020
Contributor
strega-nil
left a comment
There was a problem hiding this comment.
Mostly looks good, but I'm confused about the one thing :)
Contributor
|
Alright, awesome! Thanks so much @JackBoosY :) |
strega-nil
reviewed
Mar 5, 2020
Contributor
|
Alright, this looks good to me ! :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use #594 changes and add some other changes to fix uwp support.
Since upstream fixed the usage error, removed patch
fix-usage-lnk-error.patchand tested successfully.Related: #10254 #9971.
This port doesn't contain any features.