Pass props to the container-element#14
Closed
JasperH8g wants to merge 1 commit intoacdlite:masterfrom
JasperH8g:master
Closed
Pass props to the container-element#14JasperH8g wants to merge 1 commit intoacdlite:masterfrom JasperH8g:master
JasperH8g wants to merge 1 commit intoacdlite:masterfrom
JasperH8g:master
Conversation
mxstbr
requested changes
Sep 26, 2017
|
|
||
| return ( | ||
| <Container> | ||
| <Container {...this.props}> |
Collaborator
There was a problem hiding this comment.
Gotta change this to not pass the container prop down!
Author
|
Hmm, just found out that this was still open 😅 I'm not using this anymore, nvmd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was really missing this little feature. Mostly because of styling (and I couldn't set a
classNameon the container), but in some rare cases I'd want to add anonClickorstyleprop to the component itself. The contents of the container would be a string, so passing everything wouldn't be a problem IMHO.