pass non-remarkable props down to the container#30
Closed
chiel wants to merge 1 commit intoacdlite:masterfrom
chiel:master
Closed
pass non-remarkable props down to the container#30chiel wants to merge 1 commit intoacdlite:masterfrom chiel:master
chiel wants to merge 1 commit intoacdlite:masterfrom
chiel:master
Conversation
mcclayton
reviewed
Oct 12, 2017
| var Container = this.props.container; | ||
| var { container: Container, ...props } = this.props; | ||
|
|
||
| ['children', 'options', 'source'].forEach(prop => { |
There was a problem hiding this comment.
Should container be added here as well?
Author
There was a problem hiding this comment.
No need, it's not part of props due to the destructuring above.
There was a problem hiding this comment.
Oops, I'm blind. Carry on 👍
Would love to see this merged soon - was just about to make a PR as well until I saw yours :)
|
Would be great to merge this in! |
matiasfha
approved these changes
Nov 22, 2017
matiasfha
left a comment
matiasfha
left a comment
There was a problem hiding this comment.
This looks good. Would be nice to have it in the release
beausmith
added a commit
to HelloKip/react-remarkable
that referenced
this pull request
Apr 5, 2018
beausmith
added a commit
to HelloKip/react-remarkable
that referenced
this pull request
Apr 5, 2018
beausmith
added a commit
to HelloKip/react-remarkable
that referenced
this pull request
Apr 5, 2018
beausmith
added a commit
to HelloKip/react-remarkable
that referenced
this pull request
Apr 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw PR #14 but the author is not responding to the requested changes so I decided to open this.
It passes all props that are not used by the
Remarkablecomponent itself down to the container. I kept the keywordvarthough I suppose this could be const.