Skip to content

pass non-remarkable props down to the container #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chiel wants to merge 1 commit into from
Closed

pass non-remarkable props down to the container #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,14 @@ import Markdown from 'remarkable';
class Remarkable extends React.Component {

render() {
var Container = this.props.container;
var { container: Container, ...props } = this.props;

['children', 'options', 'source'].forEach(prop => {
Copy link

@mcclayton mcclayton Oct 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should container be added here as well?

Copy link
Author

@chiel chiel Oct 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need, it's not part of props due to the destructuring above.

Copy link

@mcclayton mcclayton Oct 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I'm blind. Carry on 👍
Would love to see this merged soon - was just about to make a PR as well until I saw yours :)

delete props[prop];
});

return (
<Container>
<Container {...props}>
{this.content()}
</Container>
);
Expand Down