Skip to content

Fix #13 {% for … reversed %}, and #14 error message#15

Open
osteele wants to merge 2 commits intoacstech:masterfrom
osteele:master
Open

Fix #13 {% for … reversed %}, and #14 error message#15
osteele wants to merge 2 commits intoacstech:masterfrom
osteele:master

Conversation

@osteele
Copy link

@osteele osteele commented Jun 11, 2017

Tested via new test cases and ./t.

This enables this library to work with some Jekyll templates that they formerly failed on.

osteele added 2 commits June 11, 2017 11:37
Also rename "modifier" -> "attribute", to match the Shopify liquid documentation <https://help.shopify.com/themes/liquid/tags/iteration-tags#for>
This also adds a separate unit test for "{% for … reversed %}". `TestTemplateRender1` also (still) tests for this; the new test makes it easier to see exactly what fails.
@osteele osteele changed the title Fix {% for … reversed %}, and error message Fix #13 {% for … reversed %}, and #14 error message Jun 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant