Skip to content

Bump guava to version 23#388

Merged
adamfisk merged 1 commit into
adamfisk:masterfrom
shs96c:guava-23
Sep 25, 2017
Merged

Bump guava to version 23#388
adamfisk merged 1 commit into
adamfisk:masterfrom
shs96c:guava-23

Conversation

@shs96c
Copy link
Copy Markdown
Contributor

@shs96c shs96c commented Aug 17, 2017

No description provided.

@shs96c shs96c mentioned this pull request Aug 18, 2017
Open
xtj7
xtj7 approved these changes Aug 25, 2017
View reviewed changes
Copy link
Copy Markdown

@xtj7 xtj7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really required to make this thing work in projects that have other guava dependencies.

This was referenced Aug 25, 2017
Open
Closed
@Laeffe
Copy link
Copy Markdown

Laeffe commented Sep 24, 2017

Friendly question, are there any plans for this Pull-Request? (Guess it's the Java 7 support that can make this one difficult).

@shs96c
Copy link
Copy Markdown
Contributor Author

shs96c commented Sep 25, 2017

Java 9 is now out, so it’d be nice to move to something more recent here. Alternatively, I can change this to use the “-android” variant of guava, which I believe is still java 7 based. In any case, bumping guava is a good idea.

@adamfisk
Copy link
Copy Markdown
Owner

adamfisk commented Sep 25, 2017

Apologies for the delay on this @shs96c. Merging! The Java 7 failures are OK at this point.

@adamfisk adamfisk merged commit 70edbe1 into adamfisk:master Sep 25, 2017
@shs96c
Copy link
Copy Markdown
Contributor Author

shs96c commented Sep 25, 2017

Fantastic. Thank you

@techpavan techpavan mentioned this pull request Oct 30, 2017
Open
@riksmith
Copy link
Copy Markdown

riksmith commented Dec 19, 2017

@adamfisk now that this is merged for some time already, can a new release be made with these changes in it?

@angel-git
Copy link
Copy Markdown

angel-git commented Jan 17, 2018

Can you guys release new version?

@britboyjohnson
Copy link
Copy Markdown

britboyjohnson commented Jun 8, 2018

Its now June 2018 nearly a year since this fix ,Please can you guys release a new version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@xtj7 xtj7 xtj7 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@shs96c @Laeffe @adamfisk @riksmith @angel-git @britboyjohnson @xtj7