Skip to content

Update pom.xml#686

Closed
mvipulbharat wants to merge 1 commit into
lightbody:masterfrom
mvipulbharat:patch-2
Closed

Update pom.xml#686
mvipulbharat wants to merge 1 commit into
lightbody:masterfrom
mvipulbharat:patch-2

Conversation

@mvipulbharat
Copy link
Copy Markdown

Updating Google Guava to 20.0 because by default Maven adds Guava 23.0 which is not compatible

@xtj7
Copy link
Copy Markdown

xtj7 commented Aug 25, 2017

That's not really a solution, especially not if you have other dependencies for Guava in your project. Browsermob itself is already prepared for Guava 22 or newer. As soon as LittleProxy is updated (adamfisk/LittleProxy#388) it should work in general.

@jekh
Copy link
Copy Markdown
Collaborator

jekh commented Sep 11, 2017

I'm going to close this since reverting to guava 20 isn't an option. The guava version is defined in the pom.xml file in the root, and we're now on guava 23, but the special Java 7 ("android") version, until we completely remove Java 7 support in BMP (which will be happening with the 2.2 line, which is going to be the next release).

@xtj7 BMP should work now with guava 23, since BMP is using a patched version of LP that has been updated to support guava 22+.

This extremely short guava deprecation sunset has been a very bad experience for a number of people. 👎 to google on this one.

@jekh jekh closed this Sep 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants