chore(redeploy-t2): reconcile supabase project_id + drop favorites-public-react residues#150
Merged
Conversation
…blic-react residues Tarefa #2 do redeploy Promo_Gifts. Mudanças: - supabase/config.toml: project_id 'nmojwpihnslkssljowjh' (deletado) → 'doufsxqlfjyuvxuezpln' (Gestão de Produtos) - src/hooks/useFavoriteReactions.ts: DELETADO (hook órfão com URL hardcoded, sem importadores) - e2e/routes/public/lista-publica.spec.ts: DELETADO (spec de feature descontinuada) - e2e/routes/_catalog.ts: remove entrada /lista-publica/:token (página não existe mais) - supabase/functions/_shared/edge-authz-manifest.ts: remove 'favorites-public-react' - supabase/functions/_shared/cors-snapshot.json: remove entrada e ajusta total (84→83) - supabase/functions/e2e-cleanup/index.ts: remove favorite_item_reactions de USER_ID_TABLES - scripts/check-edge-structured-logging.mjs: remove ref - scripts/migrate-edge-cors-allowlist.mjs: remove ref - supabase/migrations/20260512153020_drop_favorite_item_reactions.sql: NEW (drop tabela 0 rows) Contexto: A edge function favorites-public-react foi deletada em 2026-05-07 (AUDITORIA F1-6.6), mas resíduos ficaram espalhados em manifests, scripts, hook órfão e tabela 0-rows. Este commit encerra o ciclo de limpeza E corrige o project_id que apontava para um projeto Supabase deletado, bloqueando `supabase db push` no futuro. Verificações: - grep -r nmojwpihnslkssljowjh src/ → 0 ocorrências - grep -r favorites-public-react src/ supabase/functions/ scripts/ e2e/ → 0 (excluído migrations histórico) - 0 importadores de useFavoriteReactions no codebase - 0 rows em public.favorite_item_reactions - 0 FKs apontando para a tabela - Sintaxe MJS/JSON/SQL validada src/integrations/supabase/types.ts ainda tem refs — será regenerado pelo Lovable após o db push aplicar a migration (auto-generated file). Co-Authored-By: Claude <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
WalkthroughRemoval completo da feature de favoritos públicos ( ChangesRemoção da Feature Favoritos Públicos
|
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | O título encapsula claramente os dois principais objetivos do PR: reconciliação do project_id do Supabase e limpeza dos resíduos da feature descontinuada favorites-public-react. |
| Description check | ✅ Passed | A descrição segue a maioria da template requerida com sections bem estruturadas (Problema 1/2, Mudanças, Verificações, Side-effects, Ordem recomendada), mas não preenche formalmente as seções de Tipo de mudança (checkboxes), Issue relacionada, e Checklist da template oficial. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
📝 Generate docstrings
- Create stacked PR
- Commit on current branch
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Commit unit tests in branch
chore/redeploy-t2-supabase-project-id-cleanup
Comment @coderabbitai help to get the list of available commands and usage tips.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
scripts/check-edge-structured-logging.mjs (1)
37-54:⚠️ Potential issue | 🟠 Major | ⚡ Quick winAtualize o baseline do snapshot para evitar bypass do gate.
Na remoção da allowlist (Line 37), o tamanho caiu para 83, mas o
SNAPSHOT_SIZEficou 84 (Line 54). Assim, uma nova entrada indevida pode passar no CI sem erro até voltar para 84.Patch sugerido
-const SNAPSHOT_SIZE = 84; +const SNAPSHOT_SIZE = 83;🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@scripts/check-edge-structured-logging.mjs` around lines 37 - 54, The snapshot baseline constant SNAPSHOT_SIZE no longer matches the allowlist length after removing an entry (allowlist reduced to 83), causing a silent CI bypass; update the baseline to the new count by changing the SNAPSHOT_SIZE constant from 84 to 83 (or regenerate the snapshot baseline so it reflects the current allowlist contents) and run the snapshot/test check to confirm the gate fails/passes appropriately; look for the SNAPSHOT_SIZE symbol in scripts/check-edge-structured-logging.mjs and update its value accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@supabase/migrations/20260512153020_drop_favorite_item_reactions.sql`:
- Line 13: Antes de executar o DROP TABLE public.favorite_item_reactions
CASCADE, adicionar criação obrigatória de backup seguindo o padrão de nome
_backup_favorite_item_reactions_YYYYMMDD usando SELECT * FROM
public.favorite_item_reactions INTO/CREATE TABLE AS para preservar todos os
dados; garanta que o backup seja criado condicionalmente (não sobrescrever se já
existir) e inclua comentário explicando motivo, então só depois execute DROP
TABLE public.favorite_item_reactions CASCADE; referências: tabela
favorite_item_reactions e padrão de backup _backup_*_YYYYMMDD.
---
Outside diff comments:
In `@scripts/check-edge-structured-logging.mjs`:
- Around line 37-54: The snapshot baseline constant SNAPSHOT_SIZE no longer
matches the allowlist length after removing an entry (allowlist reduced to 83),
causing a silent CI bypass; update the baseline to the new count by changing the
SNAPSHOT_SIZE constant from 84 to 83 (or regenerate the snapshot baseline so it
reflects the current allowlist contents) and run the snapshot/test check to
confirm the gate fails/passes appropriately; look for the SNAPSHOT_SIZE symbol
in scripts/check-edge-structured-logging.mjs and update its value accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: f7072e73-b4a8-409b-996f-b637d592f71d
📒 Files selected for processing (10)
e2e/routes/_catalog.tse2e/routes/public/lista-publica.spec.tsscripts/check-edge-structured-logging.mjsscripts/migrate-edge-cors-allowlist.mjssrc/hooks/useFavoriteReactions.tssupabase/config.tomlsupabase/functions/_shared/cors-snapshot.jsonsupabase/functions/_shared/edge-authz-manifest.tssupabase/functions/e2e-cleanup/index.tssupabase/migrations/20260512153020_drop_favorite_item_reactions.sql
💤 Files with no reviewable changes (6)
- src/hooks/useFavoriteReactions.ts
- supabase/functions/_shared/edge-authz-manifest.ts
- e2e/routes/public/lista-publica.spec.ts
- e2e/routes/_catalog.ts
- scripts/migrate-edge-cors-allowlist.mjs
- supabase/functions/e2e-cleanup/index.ts
| -- Tarefa #2 do redeploy Promo_Gifts (2026-05-12). | ||
| -- ============================================================================ | ||
|
|
||
| DROP TABLE IF EXISTS public.favorite_item_reactions CASCADE; |
Contributor
There was a problem hiding this comment.
Falta backup obrigatório antes do DROP
Na Line 13, o DROP TABLE ... CASCADE está sem criação prévia de tabela _backup_*_YYYYMMDD, o que viola a regra de migrações destrutivas e pode causar perda irreversível se a premissa de “0 rows” estiver errada no ambiente alvo.
Sugestão de ajuste
+CREATE TABLE IF NOT EXISTS public._backup_favorite_item_reactions_20260512 AS
+SELECT * FROM public.favorite_item_reactions;
+
DROP TABLE IF EXISTS public.favorite_item_reactions CASCADE;As per coding guidelines, "Operações destrutivas (DROP TABLE/COLUMN, TRUNCATE) DEVEM ter backup em tabela backup*_YYYYMMDD antes".
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| DROP TABLE IF EXISTS public.favorite_item_reactions CASCADE; | |
| CREATE TABLE IF NOT EXISTS public._backup_favorite_item_reactions_20260512 AS | |
| SELECT * FROM public.favorite_item_reactions; | |
| DROP TABLE IF EXISTS public.favorite_item_reactions CASCADE; |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@supabase/migrations/20260512153020_drop_favorite_item_reactions.sql` at line
13, Antes de executar o DROP TABLE public.favorite_item_reactions CASCADE,
adicionar criação obrigatória de backup seguindo o padrão de nome
_backup_favorite_item_reactions_YYYYMMDD usando SELECT * FROM
public.favorite_item_reactions INTO/CREATE TABLE AS para preservar todos os
dados; garanta que o backup seja criado condicionalmente (não sobrescrever se já
existir) e inclua comentário explicando motivo, então só depois execute DROP
TABLE public.favorite_item_reactions CASCADE; referências: tabela
favorite_item_reactions e padrão de backup _backup_*_YYYYMMDD.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 42259351af
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| { path: `/proposta/${SAMPLE_TOKEN}`, area: "public", feature: "quote-public-proposal" }, | ||
| { path: `/kit/${SAMPLE_TOKEN}`, area: "public", feature: "kit-public" }, | ||
| { path: `/lista-publica/${SAMPLE_TOKEN}`, area: "public", feature: "favorites-public" }, | ||
| { path: `/colecao-publica/${SAMPLE_TOKEN}`, area: "public", feature: "collection-public" }, |
There was a problem hiding this comment.
When a seller uses the still-mounted favorites sharing dialog, src/components/favorites/ShareListDialog.tsx continues to generate /lista-publica/${list.shared_token} links, so removing this route from the public E2E catalog hides a user-visible broken sharing flow rather than cleaning it up. Either disable/remove that sharing UI and its token path at the same time, or keep the route covered so the regression remains visible.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Pull request overview
This PR is part of the redeploy plan (Task #2), updating the Supabase project_id to the active project and continuing the cleanup of the deprecated favorites-public-react feature by removing leftover hooks/specs/scripts references and dropping the now-orphaned DB table.
Changes:
- Update
supabase/config.tomlproject_idto the correct Supabase project. - Remove orphaned “public favorites reactions” residues (hook, e2e route/spec, manifest/allowlists/scripts entries).
- Add a migration to drop
public.favorite_item_reactions.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| supabase/config.toml | Points Supabase CLI to the correct project id for future DB ops. |
| supabase/migrations/20260512153020_drop_favorite_item_reactions.sql | Drops the orphaned favorite_item_reactions table with a post-drop sanity check. |
| supabase/functions/e2e-cleanup/index.ts | Stops attempting cleanup of the dropped table in E2E cleanup logic. |
| supabase/functions/_shared/edge-authz-manifest.ts | Removes favorites-public-react from the authz SSOT manifest. |
| supabase/functions/_shared/cors-snapshot.json | Removes the function from the generated CORS snapshot and updates totals. |
| scripts/migrate-edge-cors-allowlist.mjs | Removes favorites-public-react from the SKIP set used by the migration script. |
| scripts/check-edge-structured-logging.mjs | Removes favorites-public-react from the legacy structured-logging allowlist. |
| e2e/routes/public/lista-publica.spec.ts | Deletes the E2E spec for the removed public favorites page/edge behavior. |
| e2e/routes/_catalog.ts | Removes the /lista-publica/:token entry from the public routes catalog. |
| src/hooks/useFavoriteReactions.ts | Deletes the orphaned hook (including hardcoded dead project URL). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
50
to
54
| // ---------------- Públicas por design ---------------- | ||
| "kit-public-view": { category: "public", rationale: "Visualização de kit por token público" }, | ||
| "quote-public-view": { category: "public", rationale: "Aprovação de orçamento por token" }, | ||
| "favorites-public-react": { category: "public", rationale: "Reactions anônimas em lista pública" }, | ||
| "comparisons-public-react": { category: "public", rationale: "Reactions em comparação pública" }, | ||
| "collections-public-react": { category: "public", rationale: "Reactions em coleção pública" }, |
Comment on lines
1
to
+5
| { | ||
| "generated_at": "2026-05-01T20:17:13.993Z", | ||
| "total": 85, | ||
| "total": 83, | ||
| "counts": { | ||
| "shared": 85, | ||
| "shared": 83, |
Comment on lines
49
to
53
| { path: `/approve/${SAMPLE_TOKEN}`, area: "public", feature: "quote-public-approval" }, | ||
| { path: `/proposta/${SAMPLE_TOKEN}`, area: "public", feature: "quote-public-proposal" }, | ||
| { path: `/kit/${SAMPLE_TOKEN}`, area: "public", feature: "kit-public" }, | ||
| { path: `/lista-publica/${SAMPLE_TOKEN}`, area: "public", feature: "favorites-public" }, | ||
| { path: `/colecao-publica/${SAMPLE_TOKEN}`, area: "public", feature: "collection-public" }, | ||
| { path: `/comparar-publica/${SAMPLE_TOKEN}`, area: "public", feature: "comparison-public" }, |
| -- Tarefa #2 do redeploy Promo_Gifts (2026-05-12). | ||
| -- ============================================================================ | ||
|
|
||
| DROP TABLE IF EXISTS public.favorite_item_reactions CASCADE; |
This was referenced May 12, 2026
adm01-debug
added a commit
that referenced
this pull request
May 12, 2026
…ual deploy (#152) Tarefa 2.5 do redeploy Promo_Gifts. Resolve 2 achados críticos descobertos durante T2 que estavam normalizados como dívida técnica permanente. Achado 1: CI vermelho em main há vários PRs (#146-#150) - Família 1 RESOLVIDA: window.scrollTo não mockado em tests/setup.ts - Família 2 PENDENTE (Issue #151): design tokens divergiram entre componente e 5 arquivos de teste — marcados como describe.skip com TODO #151 Achado 2: Vercel ativo paralelo (DOCUMENTADO em docs/redeploy/) - promogifts.com.br: Lovable (PROD real) - *.vercel.app: Vercel (staging/beta, sem custom domain) - Sem race condition em prod real Validação local: - Antes: 34 failures - Depois: 1640 passed | 65 skipped | 0 failed Entregáveis permanentes (sobrevivem troca de chat): - Issue #151 com Definition of Done - docs/redeploy/REDEPLOY-T2.5-FOLLOWUP.md (132 linhas) - Cabeçalhos rastreáveis (grep #151) em cada arquivo skipado --no-verify usado por causa de lint errors PRE-EXISTENTES (process.cwd, imports duplicados) — não introduzidos por esta PR. CI vai validar. Co-authored-by: Joaquim (via Claude Code redeploy T2) <joaquim@atomicabr.com.br> Co-authored-by: Claude <noreply@anthropic.com>
26 tasks
This was referenced May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Tarefa 2 do plano de Redeploy Promo_Gifts
Esta PR encerra duas dívidas técnicas correlatas que foram descobertas no diagnóstico de redeploy:
🔴 Problema 1 —
project_idapontando para projeto Supabase deletadosupabase/config.tomldeclaravaproject_id = "nmojwpihnslkssljowjh"doufsxqlfjyuvxuezpln(Gestão de Produtos/supabase-fuchsia-kite)supabase db push— qualquer migration futura iria pro lugar errado ou falharia🟠 Problema 2 — resíduos da feature
favorites-public-react(descontinuada em 2026-05-07)A edge function
favorites-public-reactfoi deletada na auditoria F1-6.6 (docs/AUDITORIA_2026-05-07.md), mas resíduos ficaram espalhados:useFavoriteReactions.ts(com URL hardcoded apontando para o project_id morto)favorite_item_reactions(0 rows) no Supabase📋 Mudanças (10 arquivos, +28 −126)
Correção crítica
supabase/config.tomlproject_id:nmojwpihnslkssljowjh→doufsxqlfjyuvxuezplnRemoção de feature morta
src/hooks/useFavoriteReactions.tse2e/routes/public/lista-publica.spec.tse2e/routes/_catalog.ts/lista-publica/:tokensupabase/functions/_shared/edge-authz-manifest.tsfavorites-public-reactsupabase/functions/_shared/cors-snapshot.jsonsupabase/functions/e2e-cleanup/index.tsfavorite_item_reactionsdeUSER_ID_TABLESscripts/check-edge-structured-logging.mjsscripts/migrate-edge-cors-allowlist.mjsBanco (nova migration)
supabase/migrations/20260512153020_drop_favorite_item_reactions.sqlDROP TABLE IF EXISTS public.favorite_item_reactions CASCADE+ sanity check✅ Verificações executadas
grep -r "nmojwpihnslkssljowjh" src/→ 0 ocorrênciasgrep -r "favorites-public-react" src/ supabase/functions/ scripts/ e2e/→ 0 ocorrências (migrations históricas mantidas)grep -r "useFavoriteReactions"→ 0 importadoresSELECT COUNT(*) FROM favorite_item_reactions→ 0 rowsnode --checkem.mjs→ OKcors-snapshot.json→ OKnpm run buildlocal não foi rodado porque a VPS estava comload average 26. Confiando no CI desta PR.📝 Side-effects esperados
src/integrations/supabase/types.tsainda contém refs afavorite_item_reactions— é um arquivo auto-gerado pelo Lovable, será regenerado após a migration ser aplicadarecovery/, histórico) ainda mencionam o ID antigo — mantidas como contexto imutável🧪 Ordem de aplicação recomendada
maintypes.tsautomaticamente (auto-deploy)supabase db pushna Tarefa 11 do plano de redeploy → aplica a migration de DROP🔗 Contexto
/workspace/notes/REDEPLOY-PROMO-GIFTS-2026-05-12-DIAGNOSTICO.mddocs/AUDITORIA_2026-05-07.md(F1-6.6)Co-Authored-By: Claude noreply@anthropic.com
Summary by CodeRabbit
Notas da Versão