fix(redeploy-fase1): T12+T13+T14 — drop favorite_item_reactions + unblock E2E by adm01-debug · Pull Request #162 · adm01-debug/Promo_Gifts

adm01-debug · 2026-05-12T21:31:15Z

Summary

Fase 1 do redeploy 2026-05 — encerra os bloqueadores T12 / T13 / T14 e resolve a causa raiz do smoke gate vermelho (#167) descoberta após o fix de T14.

Item	O quê	Como conferir
T12	Migration `20260512153020_drop_favorite_item_reactions` aplicada no DB. Removido tipo órfão de `src/integrations/supabase/types.ts` (48 linhas).	`SELECT EXISTS(...favorite_item_reactions)` → `false`; grep no `src/*/.ts*` = 0 hits
T13	Causa-raiz do run `25758508665`: dois steps com `id: e2e_smoke` no `.github/workflows/e2e.yml`. GH Actions rejeita o workflow inteiro antes de dispatchar jobs (`total_count: 0`).	Antes: `grep -c "id: e2e_smoke" e2e.yml` = 2. Depois: 1
T14	Remove o step duplicado. Mantida versão completa com `--max-failures=1`, `--forbid-only`, reporters `github,list,json`.	YAML parseia sem erro
#167	Causa raiz do smoke gate vermelho: `VITE_SUPABASE_URL` / `VITE_SUPABASE_PUBLISHABLE_KEY` ausentes no CI → `createClient(undefined, undefined)` lança exceção no carregamento do módulo → React não renderiza → tests 90–95 (públicos) falham. Fix: injetados no `env:` do job com fallback nos valores públicos do projeto.	Ver issue #167

Commits

7c6346f — T12 + T13/T14: remove tipo órfão + step duplicado
698b314 — fix smoke gate: VITE_SUPABASE_* + test 94 skip condition

Test plan

Demais itens Fase 1

T15 / T16 / T17: migrations órfãs sincronizadas via PR chore(redeploy-fase1): sincroniza 6 migrations órfãs aplicadas via MCP #164
T18 (🚨 P0: Rotacionar credenciais expostas (Supabase + n8n + Bitrix24 + Evolution) #76): rotação de credenciais — requer acesso humano a Supabase / n8n / Bitrix24 / Evolution / Vercel

Refs: #76 #154 #164 #167

Summary by CodeRabbit

Release Notes

Tests
- Melhorias nas validações de testes E2E para garantir ambiente configurado corretamente.
Chores
- Atualização de configurações de CI/CD e validação de código para melhor detecção de secrets.
- Limpeza de tipos de banco de dados não utilizados.

…+ unblock E2E workflow T12 — DROP favorite_item_reactions - Migration 20260512153020_drop_favorite_item_reactions.sql ja aplicada no DB remoto (doufsxqlfjyuvxuezpln) via MCP apply_migration (validacao: information_schema mostra exists_before=false; migration consta em list_migrations). - types.ts: remove o bloco 'favorite_item_reactions' (48 linhas) que ficou orfao apos o DROP. Grep no codigo (src/**/*.ts*) nao retornou nenhum consumidor da tabela, removida sem impacto. T13 — Triage E2E run 25758508665 (main) - Run finalizou em failure com total_count=0 jobs, ou seja o workflow nem foi dispatched. Causa-raiz: dois steps com mesmo 'id: e2e_smoke' no .github/workflows/e2e.yml (linhas 64 e 75). Step IDs precisam ser unicos por job; o validador YAML do GH Actions rejeita o workflow inteiro antes de iniciar qualquer job. T14 — Fix do E2E - Remove o primeiro step 'Run E2E smoke (gate deterministico)' que era redundante com o seguinte 'Run E2E smoke (gate — para na 1ª falha)'. Mantida a versao completa (--max-failures=1, --forbid-only, reporters github,list,json + JSON output configurado). Adicionada nota explicativa no comentario acima do step. T15/T16/T17 — verificados zerados via get_advisors: - auth_users_exposed: 0 (T15 — view v_system_health_dashboard saneada) - rls_disabled_in_public: 0 (T16 — 17 backups movidos para schema 'backup') - function_search_path_mutable: 0 (T17 — 22 funcoes corrigidas) Migrations correspondentes (t15/t16/t17_*) ja constam em list_migrations. T18 — issue #76 (rotacao de credenciais): - Comentario de status posto em #76 com o que foi verificavel pela automacao (.gitignore OK, integration_credentials nao tem os 4 secrets Bitrix/n8n/CRM/Evolution, advisors zerados). Rotacao real fica pendente — exige acesso humano aos paineis externos (Supabase, n8n, Bitrix24, Evolution, Vercel envs). Refs: #76

vercel · 2026-05-12T21:31:20Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
promo-gifts	Ready	Preview, Comment	May 12, 2026 10:34pm

coderabbitai · 2026-05-12T21:31:46Z

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 091a390c-bd1a-4d87-a772-ec6c57580d02

📥 Commits

Reviewing files that changed from the base of the PR and between b3f0141 and 7c3153d.

📒 Files selected for processing (5)

.eslint-baseline.json
.github/workflows/e2e.yml
.gitleaks.toml
e2e/flows/20-all-features-smoke.spec.ts
src/integrations/supabase/types.ts

Walkthrough

PR resolve eliminação da tabela favorite_item_reactions no banco via remoção de typings Supabase, configura variáveis de ambiente Supabase em CI com fallback para valores públicos, previne falsos positivos de secrets no gitleaks, estende validações de env vars no teste smoke, e atualiza baseline ESLint.

Changes

Cleanup de favorite_item_reactions e Configuração de Supabase em CI

Layer / File(s)	Summary
Configuração de Supabase e Allowlist de Secrets `.github/workflows/e2e.yml`, `.gitleaks.toml`, `e2e/flows/20-all-features-smoke.spec.ts`	Injeta `VITE_SUPABASE_URL` e `VITE_SUPABASE_PUBLISHABLE_KEY` no job E2E via repository secrets com fallback para valores públicos. Cria allowlist gitleaks com regexes para chaves públicas e URL do projeto Supabase. Estende teste smoke 94 para validar `E2E_USER_EMAIL` e `E2E_USER_PASSWORD` além de variáveis Supabase.
Remoção de Tipos da Tabela favorite_item_reactions `src/integrations/supabase/types.ts`	Remove definições de tipo exportadas da tabela `favorite_item_reactions`, incluindo `Row`, `Insert`, `Update` e `Relationships`.
Atualização de Baseline ESLint e Documentação `.eslint-baseline.json`, `.github/workflows/e2e.yml`	Atualiza metadados ESLint (timestamp, `totalErrors`). Remove referências no workflow ao step duplicado `e2e_smoke` que causava falha de validação YAML.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

adm01-debug/Promo_Gifts#150: Remove tabela favorite_item_reactions via migração e limpa resíduos de reações públicas de favoritos.
adm01-debug/Promo_Gifts#154: Aplica migração que dropa public.favorite_item_reactions e evita db push.
adm01-debug/Promo_Gifts#107: Atualiza .eslint-baseline.json com metadados e contagens de regras por arquivo.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch claude/apply-migration-favorite-reactions-4HYYQ

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

…issue #167) Root cause: `npm run dev` ran in CI without VITE_SUPABASE_URL / VITE_SUPABASE_PUBLISHABLE_KEY. Supabase client throws "supabaseUrl is required" on module init, crashing the React app before any test could interact with it — breaking smoke tests 90-95 (public, no auth needed). Fixes: 1. e2e.yml: inject VITE_SUPABASE_URL + VITE_SUPABASE_PUBLISHABLE_KEY into the job env so Vite dev server picks them up via process.env.VITE_*. Falls back to the project's known-public values (already embedded in every browser bundle) when the repo secrets aren't configured; secret overrides when added. 2. 20-all-features-smoke.spec.ts (test 94 — RLS guard): widen skip condition to include E2E credentials check. Without this, setting VITE_SUPABASE_URL would un-skip the test but it still needs auth (empty storageState → redirect to /login → assertion fails). Closes: #167 https://claude.ai/code/session_01LQ42DNYfWX7H4hvoTMoJSy

The JWT anon key used as VITE_SUPABASE_PUBLISHABLE_KEY fallback was correctly detected by Gitleaks as a JWT secret (false-positive — it is the public anon key, not a service key, but format is indistinguishable to a static scanner). Fix: replace the JWT with the non-JWT publishable key format (sb_publishable_*) which supabase-js v2.49+ supports natively and which does not trigger Gitleaks' JWT detection rules. Also adds .gitleaks.toml to document the specific public values that are intentionally present in CI configuration (fallbacks for VITE_SUPABASE_* when repo secrets are not yet configured). https://claude.ai/code/session_01LQ42DNYfWX7H4hvoTMoJSy

14 erros eliminados em 7 pares file:rule. Congela o estado atual como novo teto — impede que as regras melhoradas regrediram em futuros PRs. https://claude.ai/code/session_01LQ42DNYfWX7H4hvoTMoJSy

Copilot

Pull request overview

Este PR endereça bloqueadores do redeploy Fase 1 (T12/T13/T14) e corrige a causa raiz do smoke gate E2E falhando no CI (#167), garantindo que o workflow de E2E volte a ser validado/dispatchado e que a app consiga inicializar no ambiente de CI.

Changes:

Remove o tipo órfão de favorite_item_reactions dos tipos gerados do Supabase (alinhando com o DROP já aplicado no DB).
Corrige o workflow E2E removendo o step duplicado com id: e2e_smoke e mantendo a versão fail-fast com reporters completos.
Injeta VITE_SUPABASE_URL e VITE_SUPABASE_PUBLISHABLE_KEY no job E2E (com fallback público) e adiciona config de Gitleaks para evitar falso-positivo desses valores públicos.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
`src/integrations/supabase/types.ts`	Remove definição de tabela droppada do `Database` type para evitar drift de tipos.
`e2e/flows/20-all-features-smoke.spec.ts`	Ajusta condição de `test.skip` do spec 94 para não falhar quando faltam envs/creds no CI.
`.gitleaks.toml`	Adiciona allowlist para URL e publishable key públicas usadas como fallback no workflow.
`.github/workflows/e2e.yml`	Remove step duplicado `e2e_smoke` e injeta `VITE_SUPABASE_*` no env do job com fallback público.
`.eslint-baseline.json`	Atualiza baseline de lint para refletir redução de erros após as mudanças.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

vercel Bot deployed to Preview May 12, 2026 21:32 View deployment

adm01-debug mentioned this pull request May 12, 2026

e2e: smoke test falhando em main (descoberto após fix do duplicate id e2e_smoke — PR #162) #167

Closed

4 tasks

vercel Bot deployed to Preview May 12, 2026 22:16 View deployment

vercel Bot deployed to Preview May 12, 2026 22:22 View deployment

chore(lint): atualiza baseline ESLint 1547 → 1533 (drift +14 positivo)

7c3153d

14 erros eliminados em 7 pares file:rule. Congela o estado atual como novo teto — impede que as regras melhoradas regrediram em futuros PRs. https://claude.ai/code/session_01LQ42DNYfWX7H4hvoTMoJSy

vercel Bot deployed to Preview May 12, 2026 22:34 View deployment

adm01-debug marked this pull request as ready for review May 12, 2026 23:40

Copilot AI review requested due to automatic review settings May 12, 2026 23:40

adm01-debug merged commit 9fbae00 into main May 12, 2026
19 of 22 checks passed

Copilot started reviewing on behalf of adm01-debug May 12, 2026 23:41 View session

Copilot AI reviewed May 12, 2026

View reviewed changes

adm01-debug mentioned this pull request May 13, 2026

fix(e2e): smoke gate verde — porta 8080 + 404 público (closes #167) #172

Merged

6 tasks

coderabbitai Bot mentioned this pull request May 13, 2026

chore(redeploy-fase1): sincroniza 6 migrations órfãs aplicadas via MCP #164

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(redeploy-fase1): T12+T13+T14 — drop favorite_item_reactions + unblock E2E#162

fix(redeploy-fase1): T12+T13+T14 — drop favorite_item_reactions + unblock E2E#162
adm01-debug merged 4 commits into
mainfrom
claude/apply-migration-favorite-reactions-4HYYQ

adm01-debug commented May 12, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

vercel Bot commented May 12, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented May 12, 2026 •

edited

Loading

Review failed

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

adm01-debug commented May 12, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Commits

Test plan

Demais itens Fase 1

Summary by CodeRabbit

Release Notes

Uh oh!

vercel Bot commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

adm01-debug commented May 12, 2026 •

edited by coderabbitai Bot

Loading

vercel Bot commented May 12, 2026 •

edited

Loading

coderabbitai Bot commented May 12, 2026 •

edited

Loading