Fix Vercel Node engine range by adm01-debug · Pull Request #180 · adm01-debug/Promo_Gifts

adm01-debug · 2026-05-13T16:22:20Z

Motivation

Pin the Node.js engine to the Node 20 major line with 20.x to avoid Vercel automatically upgrading deployments when a new major Node release appears and to keep engine constraints explicit.

Description

Change engines.node from >=20.0.0 to 20.x in package.json and update the root engines.node entry in package-lock.json to match.

Testing

Ran npm install --package-lock-only --ignore-scripts which updated the lockfile successfully, and npm run build which completed and produced the production bundle (build succeeded).

Codex Task

Summary by CodeRabbit

Release Notes

Chores
- Requisito de versão do Node.js atualizado para 20.x.

vercel · 2026-05-13T16:22:23Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
promo-gifts	Ready	Preview, Comment	May 13, 2026 4:23pm

supabase · 2026-05-13T16:22:27Z

This pull request has been ignored for the connected project doufsxqlfjyuvxuezpln because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

coderabbitai · 2026-05-13T16:22:35Z

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c4431bf4-3c1c-476c-bb06-dd173756a2ed

📥 Commits

Reviewing files that changed from the base of the PR and between 98dd5e4 and 0350362.

⛔ Files ignored due to path filters (1)

package-lock.json is excluded by !**/package-lock.json, !**/package-lock.json

📒 Files selected for processing (1)

package.json

Walkthrough

O PR atualiza o requisito de versão do Node.js em package.json, alterando de >=20.0.0 (qualquer versão 20 ou superior) para 20.x (apenas série 20, bloqueando atualizações para versão 21+).

Mudanças

Atualização de Requisito de Node.js

Layer / File(s)	Resumo
Versão mínima de Node.js `package.json`	`engines.node` muda de `>=20.0.0` para `20.x`, limitando instalações à série 20 e prevenindo saltos automáticos de major version.

Esforço estimado de revisão

🎯 1 (Trivial) | ⏱️ ~2 minutos

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch codex/fix-engines-warning-in-package.json

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull request overview

Pins the project’s Node.js engine range to the Node 20 major line to prevent platforms like Vercel from selecting a newer major Node version due to a permissive >=20.0.0 constraint.

Changes:

Updated package.json engines.node from >=20.0.0 to 20.x.
Updated the root engines.node entry in package-lock.json to match 20.x.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File	Description
package.json	Restricts `engines.node` to Node 20 major (`20.x`) to avoid unintended major upgrades in deployment environments.
package-lock.json	Aligns the lockfile’s root package `engines.node` with the updated Node 20 major constraint.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

O arquivo AUDITORIA_REDEPLOY_PROMO_GIFTS_2026-05-13_15-32 (1).md foi adicionado ao main no PR #180 e contém referências documentais a `supabase db push` (descreve o desync, não é guia operacional). Sem allowlist o guard bloqueava todo CI do branch.

…assing) * fix(tests): alinhar 5 arquivos de teste com valores reais do código - bridge.test.ts: BOOT_RETRY_ATTEMPTS=4 (era 3) - cloud-status.test.ts: FAILURE_THRESHOLD=2 requer 2 falhas consecutivas para 'down' - crm-db-fixed.test.ts: usar expect.objectContaining para tolerar header REQUEST_ID - query-config-extended.test.ts: valores reais (VERY_STABLE=86400000, STABLE=3600000, etc.) - supplier-colors.test.ts: hex reais (#1E40AF XBZ, #065F46 Spot, #991B1B Asia, #9A3412 default) Todos os 59 testes passam nos 5 arquivos. * fix(ci): adicionar audit file na allowlist do check-no-db-push O arquivo AUDITORIA_REDEPLOY_PROMO_GIFTS_2026-05-13_15-32 (1).md foi adicionado ao main no PR #180 e contém referências documentais a `supabase db push` (descreve o desync, não é guia operacional). Sem allowlist o guard bloqueava todo CI do branch. * fix(ci): corrigir timeout da quality job (25→35 min) e eliminar tripla execução da suite A suite cresceu de ~300 para 404 arquivos desde que maxThreads=2 foi configurado (PR #136). Com 2 workers, o step "Run tests" passou a levar ~21 min, excedendo o timeout de 25 min e cancelando o job antes de qualquer gate pós-teste executar. Mudanças: - `timeout-minutes: 25 → 35` na quality job - Novo script `test:quality`: exclui `tests/hooks/**` (já cobertos pelo job dedicado `hooks-tests` com timeout próprio de 10 min), reduzindo a suite de ~404 para ~319 arquivos (~16-17 min estimados com 2 workers) - Remove `test:strict-ref` e `test:coverage` da quality job — nunca chegavam a executar (job era cancelado no step anterior) e são cobertos pelos jobs `ref-warning-suite` e `integration-tests` respectivamente Tempo estimado pós-fix: setup(4) + tests(17) + gates(8) ≈ 29 min < 35 min * fix(e2e): pular regression quando E2E_USER_EMAIL não configurado O workflow já documentava "specs autenticados só se E2E_USER_EMAIL/E2E_USER_PASSWORD estiverem configurados", mas a condição não estava implementada no step de regression. Resultado: regression rodava sem credenciais → todos os testes autenticados falhavam → step 22 "Fail job se regression registrou falhas" explodía → job inteiro vermelho, mesmo com smoke ✅ e header-sticky ✅. Fix: adiciona `&& env.E2E_USER_EMAIL != ''` na condição do step de regression. Sem credenciais, o step é skipped → e2e_run.outcome == 'skipped' → step 22 não roda → job passa. * fix(ci): aumentar timeout quality job (35→45 min) e atualizar baselines * fix(ci): atualizar baselines ESLint (1256 erros) e TypeScript (855 erros) * fix(ci): atualizar baseline ESLint (1256 erros em 524 arquivos, gerado 2026-05-13) * fix(ci): aumentar timeout quality job (35→45 min) e atualizar baselines

Fix Vercel Node engine range

0350362

Copilot AI review requested due to automatic review settings May 13, 2026 16:22

adm01-debug added the codex label May 13, 2026 — with ChatGPT Codex Connector

adm01-debug merged commit 36f2192 into main May 13, 2026
13 of 18 checks passed

Copilot started reviewing on behalf of adm01-debug May 13, 2026 16:23 View session

vercel Bot deployed to Preview May 13, 2026 16:23 View deployment

Copilot AI reviewed May 13, 2026

View reviewed changes

coderabbitai Bot mentioned this pull request May 14, 2026

Hardening/onda 12 0 bump node engine #203

Merged

33 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Vercel Node engine range#180

Fix Vercel Node engine range#180
adm01-debug merged 1 commit into
mainfrom
codex/fix-engines-warning-in-package.json

adm01-debug commented May 13, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

vercel Bot commented May 13, 2026 •

edited

Loading

Uh oh!

supabase Bot commented May 13, 2026

Uh oh!

coderabbitai Bot commented May 13, 2026 •

edited

Loading

Review failed

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

adm01-debug commented May 13, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Description

Testing

Summary by CodeRabbit

Release Notes

Uh oh!

vercel Bot commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

supabase Bot commented May 13, 2026

Uh oh!

coderabbitai Bot commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Mudanças

Esforço estimado de revisão

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

adm01-debug commented May 13, 2026 •

edited by coderabbitai Bot

Loading

vercel Bot commented May 13, 2026 •

edited

Loading

coderabbitai Bot commented May 13, 2026 •

edited

Loading