Hardening/onda 12 0 bump node engine by adm01-debug · Pull Request #203 · adm01-debug/Promo_Gifts

adm01-debug · 2026-05-14T19:14:03Z

📋 Descrição

🎯 Tipo de mudança

🚀 feat — nova funcionalidade
🐛 fix — correção de bug
♻️ refactor — refatoração (sem mudança de comportamento)
🔧 chore — manutenção, deps, config
📚 docs — documentação
⚡ perf — performance
🔒 security — segurança
🚨 hotfix — correção urgente em produção
💥 breaking change — quebra compatibilidade

🔗 Issues relacionadas

Closes #
Refs #

🌐 Sistemas afetados

🧪 Como testar

✅ Checklist pré-merge

Qualidade

Código segue style guide (ESLint passa)
npx tsc --noEmit passa sem erros
Testes passam (npm run test)
Adicionei testes para novas funcionalidades quando aplicável
CodeRabbit revisou o PR (ou justificativa para skip)

Segurança

Sem secrets, tokens ou credenciais hardcoded
Variáveis de ambiente novas documentadas
Sem console.log com payloads sensíveis (usar logger.*)
RLS revisado se houve mudança em tabelas
Edge functions: input validado com Zod

Documentação

Atualizei docs (README / CHANGELOG / docs/) se necessário
Memória atualizada (mem://) se a mudança afetar arquitetura/regras
Migrations com backup em _backup_*_YYYYMMDD se destrutivas

UI

Componentes usam tokens semânticos (sem cores hardcoded)
Screenshots / vídeo anexados (se mudança visual)

📸 Screenshots (se UI)

🔄 Plano de rollback

⚠️ Notas para o reviewer

Summary by cubic

Pins Node version with a single source of truth and aligns CI to it. Updates Node engine range to meet vite@7 and jsdom@29 requirements for Onda 12.x.

Dependencies
- Added .nvmrc with Node 20.20.2.
- Updated "engines.node" to ^20.19.0 || >=22.12.0 in package.json.
- CI (ci.yml, e2e.yml) now uses node-version-file: '.nvmrc' instead of hardcoded versions.
- Prevents using early 20.x (e.g., 20.0) that breaks with vite@7 and jsdom@29.
Migration
- Run nvm use (or nvm install then nvm use) to switch to 20.20.2 locally; >=22.12.0 also supported.
- Run npm ci to rebuild modules under the new Node version.

^{Written for commit eda94aa. Summary will update on new commits.}

Summary by CodeRabbit

Chores

Configurações de ambiente de desenvolvimento e pipelines de integração contínua foram atualizadas para utilizar a versão do Node.js especificada no arquivo de configuração do repositório, garantindo consistência entre diferentes ambientes de execução.
Requisitos de versão do Node.js foram expandidos para aceitar versões 20.19.0 ou posteriores, bem como versões 22.12.0 ou superiores, aumentando a flexibilidade de compatibilidade.

…rsion)

Required floor for vite@7 (Onda 12.3) and jsdom@29 (Onda 12.1). Previous "20.x" was too loose (accepted 20.0).

Lê Node version do .nvmrc (SSOT) em vez de hardcoded "20".

Substitui hardcoded "node-version: 20" por node-version-file: '.nvmrc' em todos os 10 jobs (smoke, quality, integration-tests, critical-e2e, ref-warning-suite, hooks-tests, price-freshness-tests, cloud-status-tests, edge-functions-typecheck, theme-validation). SSOT: Node version vive em .nvmrc; workflows leem dali.

vercel · 2026-05-14T19:14:08Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
promo-gifts	Ready	Preview, Comment	May 14, 2026 7:14pm

supabase · 2026-05-14T19:14:11Z

This pull request has been ignored for the connected project doufsxqlfjyuvxuezpln because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

coderabbitai · 2026-05-14T19:14:16Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 82504d4f-20b1-431c-8096-e8617f95504e

📥 Commits

Reviewing files that changed from the base of the PR and between 357caef and eda94aa.

📒 Files selected for processing (4)

.github/workflows/ci.yml
.github/workflows/e2e.yml
.nvmrc
package.json

Resumo

Sincronização de versão Node.js via .nvmrc e atualização de manifesto: múltiplos workflows CI/E2E passam a usar node-version-file: '.nvmrc', versão atualizada para 20.20.2, e engines.node expandido para aceitar Node ^20.19.0 ou >=22.12.0.

Alterações

Sincronização de Versão Node.js

Camada / Arquivo(s)	Resumo
Atualização de versão Node.js `.nvmrc`, `package.json`	`.nvmrc` atualizado para `20.20.2` e `engines.node` em `package.json` ampliado de `20.x` para `^20.19.0
Workflows configurados para usar .nvmrc `.github/workflows/ci.yml`, `.github/workflows/e2e.yml`	Dez jobs no workflow CI (`smoke`, `quality`, `integration-tests`, `critical-e2e`, `ref-warning-suite`, `hooks-tests`, `price-freshness-tests`, `cloud-status-tests`, `edge-functions-typecheck`, `theme-validation`) e job E2E passam de `node-version: 20` para `node-version-file: '.nvmrc'`, garantindo sincronização automática com versão declarada.

Esforço estimado de revisão

🎯 1 (Trivial) | ⏱️ ~3 minutos

Mudanças de configuração repetitivas e homogêneas: atualização de versão em arquivo de manifest, propagação dessa versão nos workflows através de um padrão consistente. Sem lógica complexa, sem dependências externas, sem riscos de regressão funcional.

PRs possivelmente relacionadas

adm01-debug/Promo_Gifts#180: Ambas PRs modificam restrição de versão Node em package.json (engines.node); PR #180 altera para 20.x enquanto esta amplia para ^20.19.0 || >=22.12.0.

Labels sugeridas

codex

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	O título descreve com precisão a mudança principal: atualização da versão do Node.js nos arquivos de configuração e workflows.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch hardening/onda-12-0-bump-node-engine

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull request overview

This PR centralizes the project’s Node.js version selection by adding .nvmrc and wiring GitHub Actions to read from it, while broadening the Node engine range in package.json.

Changes:

Adds a root .nvmrc.
Updates CI and E2E workflows to use node-version-file.
Updates package.json Node engine compatibility.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
`package.json`	Broadens supported Node versions in `engines.node`.
`.nvmrc`	Adds the Node version consumed by local tooling and CI.
`.github/workflows/ci.yml`	Switches CI jobs from hardcoded Node 20 to `.nvmrc`.
`.github/workflows/e2e.yml`	Switches E2E workflow Node setup to `.nvmrc`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

cubic-dev-ai

1 issue found across 4 files

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name=".nvmrc">

<violation number="1" location=".nvmrc:1">
P1: `.nvmrc` is pinning Node 20, which is already EOL. Use a currently supported LTS major to keep receiving security and bug-fix updates.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.}

cubic-dev-ai · 2026-05-14T19:16:45Z

@@ -0,0 +1 @@
+20.20.2


P1: .nvmrc is pinning Node 20, which is already EOL. Use a currently supported LTS major to keep receiving security and bug-fix updates.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At .nvmrc, line 1: <comment>`.nvmrc` is pinning Node 20, which is already EOL. Use a currently supported LTS major to keep receiving security and bug-fix updates.</comment> <file context> @@ -0,0 +1 @@ +20.20.2 </file context>

Suggested change

20.20.2

22

adm01-debug added 4 commits May 14, 2026 16:00

chore(onda-12.0): add .nvmrc pinning Node 20.20.2 (SSOT for engine ve…

2f2d59b

…rsion)

chore(onda-12.0): bump engines.node to ^20.19.0 || >=22.12.0

6ea2ee9

Required floor for vite@7 (Onda 12.3) and jsdom@29 (Onda 12.1). Previous "20.x" was too loose (accepted 20.0).

chore(onda-12.0): e2e.yml usa node-version-file: '.nvmrc'

4fe61c9

Lê Node version do .nvmrc (SSOT) em vez de hardcoded "20".

Copilot AI review requested due to automatic review settings May 14, 2026 19:14

Copilot started reviewing on behalf of adm01-debug May 14, 2026 19:14 View session

Copilot AI reviewed May 14, 2026

View reviewed changes

cubic-dev-ai Bot reviewed May 14, 2026

View reviewed changes

adm01-debug merged commit dc00e46 into main May 14, 2026
24 of 26 checks passed

adm01-debug deleted the hardening/onda-12-0-bump-node-engine branch May 14, 2026 19:21

adm01-debug mentioned this pull request May 14, 2026

chore(onda-12.1): bump jsdom 20 → 29 (fecha 3 vulns NPM) #205

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hardening/onda 12 0 bump node engine#203

Hardening/onda 12 0 bump node engine#203
adm01-debug merged 4 commits into
mainfrom
hardening/onda-12-0-bump-node-engine

adm01-debug commented May 14, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

vercel Bot commented May 14, 2026

Uh oh!

supabase Bot commented May 14, 2026

Uh oh!

coderabbitai Bot commented May 14, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

cubic-dev-ai Bot left a comment

Uh oh!

cubic-dev-ai Bot May 14, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

adm01-debug commented May 14, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📋 Descrição

🎯 Tipo de mudança

🔗 Issues relacionadas

🌐 Sistemas afetados

🧪 Como testar

✅ Checklist pré-merge

Qualidade

Segurança

Documentação

UI

📸 Screenshots (se UI)

🔄 Plano de rollback

⚠️ Notas para o reviewer

Summary by cubic

Summary by CodeRabbit

Chores

Uh oh!

vercel Bot commented May 14, 2026

Uh oh!

supabase Bot commented May 14, 2026

Uh oh!

coderabbitai Bot commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Resumo

Alterações

Esforço estimado de revisão

PRs possivelmente relacionadas

Labels sugeridas

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

adm01-debug commented May 14, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 14, 2026 •

edited

Loading

cubic-dev-ai Bot May 14, 2026 •

edited

Loading