This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Merged
Conversation
…ers should return a promise.
Contributor
|
It looks lie it would be useful for done to return the dialog as proposed in #4087.Thanks for fixing this and sorry for breaking it. |
ghost
assigned
Contributor
|
Open to @TomMalbran |
Contributor
There was a problem hiding this comment.
This could now be $dlg = dialog.getElement()
Contributor
|
Everything else seems ok, thanks for fixing this. |
Member
Author
|
@TomMalbran fixes ready |
Contributor
|
This is working great now. Merging :) |
TomMalbran
added a commit
that referenced
this pull request
Jun 6, 2013
Update usage of new Dialogs API
Contributor
|
@jasonsanjose Travis sent me an error report after this merge: https://travis-ci.org/adobe/brackets/builds/7857943 but there wasn't any error when I merged, is everything ok or did something broke? |
Member
Author
|
@TomMalbran We've seen some intermittent issues with travis lately. I'll kick off a new build. |
Contributor
|
Ok, thanks. Just checking if everything was ok or not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #4081