This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Fix bug #4613 - Globally preventDefault() on *all* link clicks#4695
Merged
JeffryBooher merged 1 commit intomasterfrom Aug 8, 2013
Merged
Fix bug #4613 - Globally preventDefault() on *all* link clicks#4695JeffryBooher merged 1 commit intomasterfrom
JeffryBooher merged 1 commit intomasterfrom
Conversation
…EF to navigate away from Bracket's index.html under any circumstances. Remove ad-hoc preventDefault() calls from individual bits of UI code.
Contributor
|
Unit tests pass. Change looks acceptable. Merging. |
JeffryBooher
added a commit
that referenced
this pull request
Aug 8, 2013
Fix bug #4613 - Globally preventDefault() on *all* link clicks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bug #4613 - Globally preventDefault() on all link clicks, since we never want CEF to navigate away from Bracket's index.html under any circumstances. Remove ad-hoc preventDefault() calls from individual bits of UI code.