Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
175 commits
Select commit Hold shift + click to select a range
4e28a42
New Component Card
snowystinger Aug 3, 2021
5c09b07
no divider when no footer
snowystinger Aug 3, 2021
0ca89d7
add the start of quiet
snowystinger Aug 4, 2021
87aaceb
Quiet cards, tests
snowystinger Aug 6, 2021
bf51f37
fix aspect ratio for quiet
snowystinger Aug 6, 2021
98401e4
more images, fix tall images in quiet
snowystinger Aug 6, 2021
ac3b6b6
Fix up heights
snowystinger Aug 6, 2021
469d8cf
Break out styles for tile grid
snowystinger Aug 6, 2021
e4432f2
Add selection, tabIndex and focus
snowystinger Aug 7, 2021
dc608d0
minor improvement to horizontal
snowystinger Aug 7, 2021
e651bb5
fix border between image and body
snowystinger Aug 7, 2021
1dfef38
add comment
snowystinger Aug 8, 2021
065eec9
update based on daniels changes
snowystinger Aug 9, 2021
1d094f5
Add a context object
snowystinger Aug 9, 2021
d50c4b2
merge from daniel
snowystinger Aug 9, 2021
95eae78
fix quiet card styles
snowystinger Aug 9, 2021
59a7345
fix negation css selector
snowystinger Aug 10, 2021
400e699
fixing image preview height, rounded corners
snowystinger Aug 10, 2021
324f705
change clip-path to match spectrum
snowystinger Aug 10, 2021
2fc1841
plop setup
LFDanLu Jul 27, 2021
75b2420
saving progress
LFDanLu Aug 3, 2021
a97454c
BaseLayout and GridLayout progress
LFDanLu Aug 4, 2021
f5a75ba
more progress with converting v2 gridlayout
LFDanLu Aug 5, 2021
195f631
working grid layout barring some collection oddities
LFDanLu Aug 5, 2021
102e021
changing it so that I pass the list collection to the Virtualizer ins…
LFDanLu Aug 5, 2021
cb8bf59
cleanup and some typescript fixes
LFDanLu Aug 5, 2021
8835d7f
fixing getVisibleLayoutInfos and adding centered wrapper
LFDanLu Aug 5, 2021
35ad759
fixing loader/placeholder not showing up
LFDanLu Aug 5, 2021
a187187
using keyboard delegate from grid layout
LFDanLu Aug 5, 2021
7490afd
more cleanup and adding intl files
LFDanLu Aug 6, 2021
8905b70
updating story format
LFDanLu Aug 6, 2021
1784212
fixing keyboard nav when layout is directly provided instead of const…
LFDanLu Aug 6, 2021
0128ae8
tentative change to make onSelectionChange return the card key
LFDanLu Aug 6, 2021
4374138
renaming package name to cards to align with Robs work
LFDanLu Aug 6, 2021
3f81d89
clean up some remaining card -> cards from package rename
LFDanLu Aug 6, 2021
156c94f
adding rough focus style for testing and attempting to unify card
LFDanLu Aug 6, 2021
1a8f828
adding class name for card grid
LFDanLu Aug 6, 2021
80396fc
fixing refs passed into CardBase
LFDanLu Aug 6, 2021
603ee87
updating cardbase and cardview to use correct context and pass cardvi…
LFDanLu Aug 9, 2021
5aab366
fixing loadingMore state and card content cutoff
LFDanLu Aug 9, 2021
4ff0399
actuallying fixing loadingMore state
LFDanLu Aug 9, 2021
7b14e2c
adding typeahead to gridlayout
LFDanLu Aug 9, 2021
c5058ba
updating stories to have different image sizes
LFDanLu Aug 10, 2021
39986ab
fixing image preview height, rounded corners, and updating card class
LFDanLu Aug 10, 2021
17c6d88
cleanup and typescript stuff
LFDanLu Aug 10, 2021
1d59d48
fixing Card forwardRef collectionBuilder error
LFDanLu Aug 10, 2021
6ca01bc
adding Gallery and waterfall layout wips
LFDanLu Aug 11, 2021
a0fa138
progress on gallery layout and removing cache stuff
LFDanLu Aug 11, 2021
45ee99c
fixing up/down/pgUp/pgDown for gallery and changing to layoutType ins…
LFDanLu Aug 11, 2021
1a29ce8
Adding in progress waterfall layout and refactor to share things in b…
LFDanLu Aug 12, 2021
79e8807
adding button to remove cards in story
LFDanLu Aug 12, 2021
13aecca
updating card css for specific layout, saving gallery layout progress…
LFDanLu Aug 17, 2021
b983d04
fixing missing stuff from rebase
LFDanLu Aug 17, 2021
062679c
fixing rtl nav in waterfall and adjusting closest layout info calcula…
LFDanLu Aug 18, 2021
2dc1c2b
refine closestRight/Left logic in waterfall layout some more
LFDanLu Aug 18, 2021
1dad042
Add all quiet variations of constraints
snowystinger Aug 19, 2021
b77991c
remove erroneous entry in package.json
snowystinger Aug 19, 2021
bf55241
Merge branch 'main' into starter-cards
snowystinger Aug 19, 2021
76fb2c7
Polished standard vertical
snowystinger Aug 19, 2021
c9aa1ed
Merge branch 'starter-cards' of github.com:adobe/react-spectrum into …
snowystinger Aug 19, 2021
866b9bb
polishing horizontal
snowystinger Aug 19, 2021
e1e7111
comments and horizontal focus ring
snowystinger Aug 20, 2021
62bd1cb
fix word wrapping
snowystinger Aug 20, 2021
0f3ee9c
remove extraneous props
snowystinger Aug 20, 2021
c99e151
Fix Story names
snowystinger Aug 20, 2021
57927b6
Add different descriptions
snowystinger Aug 20, 2021
6d8bad4
remove descriptions that are varying in the gridviews, they'll be tes…
snowystinger Aug 20, 2021
8ddc973
leave long descriptions in waterfall
snowystinger Aug 20, 2021
c7c88bd
Fix firefox horizontal
snowystinger Aug 21, 2021
11f7ce3
update comments
snowystinger Aug 21, 2021
75b53c8
Merge branch 'starter-cards' of github.com:adobe/react-spectrum into …
LFDanLu Aug 21, 2021
ca120cd
Merge branch 'starter-cards' of github.com:adobe/react-spectrum into …
LFDanLu Aug 21, 2021
27e02bc
Refactor classnames
snowystinger Aug 23, 2021
80eae2a
Merge branch 'starter-cards' of github.com:adobe/react-spectrum into …
LFDanLu Aug 23, 2021
1914303
fixing gallery layout card sizing and fixing focus ring/border for wa…
LFDanLu Aug 23, 2021
c5dbe09
add an avatar placeholder
snowystinger Aug 24, 2021
71099ee
fix ts for filler element
snowystinger Aug 24, 2021
8dbe87e
update text colors
snowystinger Aug 24, 2021
8d5ddfa
Add colored svg story
snowystinger Aug 25, 2021
9495d5c
Merge branch 'main' into starter-cards
snowystinger Aug 25, 2021
9f1679c
use real avatar
snowystinger Aug 25, 2021
b11382a
fix tests
snowystinger Aug 25, 2021
d451b4e
removing sizeToFit from cardview
LFDanLu Aug 26, 2021
b062742
Merge branch 'starter-cards' of github.com:adobe/react-spectrum into …
LFDanLu Aug 26, 2021
0653093
adding baseline chromatic stories and removing cardview mdx
LFDanLu Aug 26, 2021
8ac925b
removing drag and drop v2 code for now
LFDanLu Aug 26, 2021
02f585a
move common getKeyLeft/Right to baseLayout
LFDanLu Aug 26, 2021
f6d4584
remove logic for placeholder images and updateItemSize in gallery/grid
LFDanLu Aug 26, 2021
c97904c
tentative fix to make waterfall cards follow the min item size set
LFDanLu Aug 26, 2021
5143b4c
fixing partial lint
LFDanLu Aug 27, 2021
51b1e87
refactor stories
LFDanLu Aug 27, 2021
116d46f
Address standard cards min image height
snowystinger Aug 27, 2021
40e5ff3
fix overlay of selected blue
snowystinger Aug 27, 2021
5cb4d13
adding selection stories
LFDanLu Aug 27, 2021
869d2f2
removing allowsCellSelection for another approach
LFDanLu Aug 27, 2021
5ffad39
Merge branch 'starter-cards' of github.com:adobe/react-spectrum into …
LFDanLu Aug 27, 2021
afca79c
removing previous min height guard from waterfall layout
LFDanLu Aug 27, 2021
4978a23
adding async stories and properly removing loading spinner when loadi…
LFDanLu Aug 27, 2021
e6e9856
adding stories to check placeholder cleanup
LFDanLu Aug 27, 2021
83d00bb
add focus halo for quiet
snowystinger Aug 28, 2021
1536f13
Merge branch 'starter-cards' of github.com:adobe/react-spectrum into …
LFDanLu Aug 30, 2021
f04a33d
Min padding square images
snowystinger Aug 30, 2021
8f7d3ad
cleanup
snowystinger Aug 30, 2021
3742fb0
adding tests in progress
LFDanLu Aug 31, 2021
8f7d487
Merge branch 'main' into starter-cards
snowystinger Aug 31, 2021
50ae4b8
update comments
snowystinger Aug 31, 2021
2d55622
adding keyboard nav for the rest of the card view layout tests
LFDanLu Aug 31, 2021
23a2bb1
updating waterfall layout logic for left/right key
LFDanLu Aug 31, 2021
1d825e1
adding basic selection and loading tests for CardView
LFDanLu Aug 31, 2021
0d5054e
fixing lint and updating Layout type provided to CardView
LFDanLu Sep 1, 2021
8839f72
Merge branch 'starter-cards' of github.com:adobe/react-spectrum into …
LFDanLu Sep 1, 2021
e70cd00
removing card size for now
LFDanLu Sep 1, 2021
c81d5f5
fixing keyboard/mouse selection for CardView
LFDanLu Sep 1, 2021
3e79fb9
adjusting virtualizer contains style for card view halo rings
LFDanLu Sep 1, 2021
700d797
ellipsis for one line description on tile and gallery cards
snowystinger Sep 1, 2021
80ae452
approach #2 where we adjust for halo focus ring in the layout
LFDanLu Sep 1, 2021
4431b57
Merge branch 'starter-cards' of github.com:adobe/react-spectrum into …
LFDanLu Sep 1, 2021
678767d
adding custom layout option stories
LFDanLu Sep 2, 2021
82ebb6f
make static stories more varied
LFDanLu Sep 2, 2021
0d30421
Merge branch 'issue_2083_cardview' of github.com:adobe/react-spectrum…
LFDanLu Sep 2, 2021
4810515
Pointer events none on standard card overlay
snowystinger Sep 2, 2021
8b81ea9
Small Avatar adjustments
snowystinger Sep 2, 2021
66c76f4
add a couple explanations to stories
snowystinger Sep 2, 2021
1316336
adding a no thin images story to gallery layout
LFDanLu Sep 2, 2021
9db0e5e
Merge branch 'issue_2083_cardview' of github.com:adobe/react-spectrum…
LFDanLu Sep 2, 2021
388726e
Revert "approach #2 where we adjust for halo focus ring in the layout"
LFDanLu Sep 2, 2021
7b8b15f
replace clip-paths not needed anymore
snowystinger Sep 2, 2021
cb8ae8d
clarify comment
snowystinger Sep 2, 2021
22757d8
remove cards aria
snowystinger Sep 2, 2021
7b9ca83
Merge branch 'starter-cards' of github.com:adobe/react-spectrum into …
LFDanLu Sep 2, 2021
1b40bca
Merge branch 'issue_2083_cardview' of github.com:adobe/react-spectrum…
LFDanLu Sep 2, 2021
bc6abf8
Fix blue flash on deselect
snowystinger Sep 2, 2021
d4109f5
updating cardview loadmore test
LFDanLu Sep 2, 2021
376e39e
Only show checkbox for hover and visible focus
snowystinger Sep 2, 2021
d9749ca
fix lint
snowystinger Sep 2, 2021
4315d6a
fixing empty placeholder remaining when items load
LFDanLu Sep 3, 2021
cdca8c7
change alignment of heading/detail
snowystinger Sep 3, 2021
c5d6604
fixing grid layout so margins are properly set on both sides
LFDanLu Sep 3, 2021
394ded6
Handle no preview provided
snowystinger Sep 3, 2021
3651b0a
Showcase large scale for cards in grids
snowystinger Sep 3, 2021
d25c6d7
Merge branch 'main' into starter-cards
snowystinger Sep 3, 2021
410c344
add support for CSF Provider context
snowystinger Sep 3, 2021
0983e76
Merge branch 'starter-cards' of github.com:adobe/react-spectrum into …
LFDanLu Sep 3, 2021
227c0b9
Merge branch 'issue_2083_cardview' of github.com:adobe/react-spectrum…
LFDanLu Sep 3, 2021
0570ab9
fixing the tests after layout update in gridlayout
LFDanLu Sep 3, 2021
3e7c3fc
updating stories for resize and getting rid of focus ring on cardview…
LFDanLu Sep 3, 2021
452e281
updating loading and loading more arabic strings
LFDanLu Sep 3, 2021
1e168f5
fixing pageup/pagedown for extremely tall items
LFDanLu Sep 3, 2021
42ead5e
moving contain style changes to card specific style
LFDanLu Sep 7, 2021
9c75d4c
updating layouts to have the same margin + gutter spacing per design
LFDanLu Sep 7, 2021
31791fc
preventing scrolling from happening when user clicks on virtualizer item
LFDanLu Sep 7, 2021
c933971
making card story heights 90 vh so scrolling is easier on mobile
LFDanLu Sep 7, 2021
cc39884
refactor layouts to use gridCollection
LFDanLu Sep 14, 2021
ab4a7c0
fixing lint
LFDanLu Sep 14, 2021
60fca3b
Do aspect ratio directly on our image
snowystinger Sep 15, 2021
f36bcc5
Merge branch 'main' into starter-cards
snowystinger Sep 15, 2021
fc950f3
add back import
snowystinger Sep 15, 2021
f679eb8
Merge branch 'starter-cards' of github.com:adobe/react-spectrum into …
LFDanLu Sep 15, 2021
ebec6f1
fixing dependency array
LFDanLu Sep 15, 2021
50a473b
adding TODO for Card typing
LFDanLu Sep 15, 2021
ed3955e
Merge branch 'issue_2083_cardview' of github.com:adobe/react-spectrum…
LFDanLu Sep 16, 2021
d90bca5
Updating gallery layout to use Robs distribution logic from v2 (#2289)
LFDanLu Sep 16, 2021
f097117
Rough Cardview scale support (#2297)
LFDanLu Sep 16, 2021
ba03c88
clean up from review
LFDanLu Sep 16, 2021
09e1879
moving validate into baselayout
LFDanLu Sep 16, 2021
1dbcc75
title for single line cards always actionbutton height
snowystinger Sep 17, 2021
42f437e
Remove extraneous whitespace and enforce title minheight
snowystinger Sep 17, 2021
e9c9be8
unselectable cards are not interactable, transitions for selection color
snowystinger Sep 17, 2021
d438470
disable text selection across all cards
snowystinger Sep 17, 2021
92295e9
Disable dragging the image in standalone where possible
snowystinger Sep 17, 2021
2325c07
Merge branch 'starter-cards' into issue_2083_cardview
snowystinger Sep 20, 2021
1360113
Updating dep versions
snowystinger Sep 20, 2021
d72bd34
Merge branch 'issue_2083_cardview' into cardview_followup
snowystinger Sep 20, 2021
e8ffba9
fix range dep
snowystinger Sep 20, 2021
80c5d3a
Merge branch 'issue_2083_cardview' into cardview_followup
snowystinger Sep 20, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@
"@storybook/addon-links": "^6.1.10",
"@storybook/react": "^6.1.10",
"@testing-library/dom": "^8.0.0",
"@testing-library/jest-dom": "^5.11.4",
"@testing-library/jest-dom": "^5.14.1",
"@testing-library/react": "^12.0.0",
"@testing-library/react-hooks": "^3.4.1",
"@testing-library/user-event": "^12.1.3",
Expand Down
5 changes: 0 additions & 5 deletions packages/@adobe/spectrum-css-temp/components/asset/index.css
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ governing permissions and limitations under the License.
@import '../commons/index.css';

.spectrum-Asset {
width: 100%;
height: 100%;
display: flex;
align-items: center;
justify-content: center;
Expand All @@ -29,9 +27,6 @@ governing permissions and limitations under the License.

.spectrum-Asset-folder,
.spectrum-Asset-file {
width: 100%;
height: 100%;
min-width: var(--spectrum-asset-icon-min-width);
max-width: var(--spectrum-asset-icon-max-width);
margin: var(--spectrum-asset-icon-margin);
}
Loading