Cardview followup#2271
Closed
LFDanLu wants to merge 175 commits into
Closed
Conversation
add long string stories
add layers
need to figure out what to pass to Virtualizer and if I should sync the collection in GridLayout with the virtulizer layout
…tead makes it so I dont have to check the childNodes but tbh doesnt seem like that big of a difference
|
Build successful! 🎉 |
* updating gallery layout to use Robs distribution logic from v2 * force gallery images to match minItem width even if space alotted to the virtualizer is less than the minItem width * partial fix for min item height need to figure out why the partition doesnt quite work
* adjusting item padding based on scale * removing protected from itemPadding so we can support scale if user only provides the layout constructor to CardView, we have to set itemPadding values for M/L scale for them after initializing the layout
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
# Conflicts: # packages/@react-spectrum/cards/src/CardBase.tsx
# Conflicts: # packages/@react-spectrum/cards/package.json
|
Build successful! 🎉 |
|
Build successful! 🎉 |
devongovett
force-pushed
the
issue_2083_cardview
branch
from
92407c7 to
54a1454
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: