CardView followup patch#2362
Merged
Merged
Conversation
Co-authored-by: Danni <drobinson@livefyre.com>
Co-authored-by: Danni <drobinson@livefyre.com>
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
LFDanLu
approved these changes
Sep 21, 2021
Member
LFDanLu
left a comment
LFDanLu
left a comment
There was a problem hiding this comment.
LGTM, compared the diff of my local branch with this one and didn't find anything amiss. Pushed a small change to readd the ellipsis to the loadingMore strings
|
Build successful! 🎉 |
|
Build successful! 🎉 |
dannify
approved these changes
Sep 21, 2021
paulkenney
added a commit
that referenced
this pull request
Sep 23, 2021
* main: Rename cards packages -> card Bump theme packages add rest of style props to action menu (#2374) Publish Add Autocomplete package (#2371) CardView followup patch (#2362) Creating chromatic baseline for fixing combobox to use useFormProps (#2334) Correcting Arabic translations of Loading and Loading more (#2359)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #2271. Rebasing was too hard.