add rest of style props to action menu#2374
Conversation
|
Build successful! 🎉 |
| {...buttonProps} | ||
| UNSAFE_className={props.UNSAFE_className} | ||
| UNSAFE_className={styleProps.className} | ||
| UNSAFE_style={styleProps.style} |
There was a problem hiding this comment.
Why not pass through other props from props here? This will miss some style props (e.g. hidden), and more if we change the way they work in the future.
There was a problem hiding this comment.
good call, forgot about hidden, would we do it like
{...styleProps as Omit<StyleProps, 'className' | 'style'>}
or would a utility to re-convert to UNSAFE be a good idea for cases like this?
There was a problem hiding this comment.
why does it need to be unsafe? You don't need to call useStyleProps at all here, just pass them through and let ActionButton handle it?
<ActionButton {...props}>There was a problem hiding this comment.
Ah, was trying not to pass through all props in case there was overlap with Menu or MenuTrigger
I suppose in cases like that we'd create a specific object for passing through directly to one of those though, so it'd be fine
|
Build successful! 🎉 |
* main: Rename cards packages -> card Bump theme packages add rest of style props to action menu (#2374) Publish Add Autocomplete package (#2371) CardView followup patch (#2362) Creating chromatic baseline for fixing combobox to use useFormProps (#2334) Correcting Arabic translations of Loading and Loading more (#2359)
4 participants
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: