Whcm buttons#2626
Merged
Merged
Conversation
Member
|
@jnurthen my XD is broken even after a reinstall, I'll try and debug it soon. In the meantime can you confirm that a unfocused CTA button should have the same color fill as the left color picker box for "Button Text" in the Windows High Contrast setting? The screenshot you attached shows the CTA button while focused. EDIT: Nvm, got my XD working again after a restart |
LFDanLu
reviewed
Dec 16, 2021
| .spectrum-ActionButton { | ||
| &:focus-ring, | ||
| &.is-focused { | ||
| outline: CanvasText solid 3px; |
Member
Member
There was a problem hiding this comment.
Note: Made a change to remove this here: b3d5e33, will need to ask Spectrum if it should be a halo focus ring or not
…ectrum into jnurthen-WHCM---buttons
removed most of the css properties and replaced with var overrides
snowystinger
approved these changes
Dec 22, 2021
Member
snowystinger
left a comment
There was a problem hiding this comment.
lgtm, worked with @LFDanLu I can't currently test on a windows machine, but this is what I expect
devongovett
approved these changes
Dec 22, 2021
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Partially resolves #2529
✅ Pull Request Checklist:
📝 Test Instructions:
Screenshots
Button Before

### Button After
### ToggleButton Before
### ToggleButton After
### LogicButton Before
### LogicButton After🧢 Your Project: