Skip to content

WHCM fixes for spectrum-css#1431

Merged
GarthDB merged 26 commits into
adobe:mainfrom
jnurthen:nurthen/WHCM
May 9, 2022
Merged

WHCM fixes for spectrum-css#1431
GarthDB merged 26 commits into
adobe:mainfrom
jnurthen:nurthen/WHCM

Conversation

@jnurthen
Copy link
Copy Markdown
Contributor

@jnurthen jnurthen commented Apr 25, 2022

This fixes Windows High Contrast mode for the following components:

  • accordion
  • actionbutton
  • avatar
  • breadcrumb
  • button
  • calendar
  • clearbutton
  • closebutton
  • menu
  • progressbar
  • progresscircle
  • radio
  • rating
  • sidenav
  • slider
  • statuslight
  • stepper
  • switch
  • tag
  • textfield
  • toast
  • tooltip

This is a forward port of react-spectrum PRs

Description

How and where has this been tested?

  • How this was tested:
  • Browser(s) and OS(s) this was tested with:

Screenshots

To-do list

  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • This pull request is ready to merge.

@jnurthen jnurthen marked this pull request as ready for review April 28, 2022 23:14
Copy link
Copy Markdown
Collaborator

@pfulton pfulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, @jnurthen. Thanks so much for taking care of these changes. I had just one question here.

Comment thread components/calendar/skin.css Outdated
Copy link
Copy Markdown
Member

@lazd lazd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just remove any dead code!

@GarthDB GarthDB merged commit ddd04de into adobe:main May 9, 2022
@GarthDB
Copy link
Copy Markdown
Member

GarthDB commented May 9, 2022

Released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants