Fix ComboBox left/right arrows so they move the input cursor when the menu is open#3415
Merged
Conversation
these are extraneous now since useGridListItem handles the left and right arrows in ListView. Normal lists dont need to handle left and right
LFDanLu
commented
Aug 19, 2022
Comment on lines
-380
to
-387
| getKeyLeftOf(key: Key): Key { | ||
| return key; | ||
| } | ||
|
|
||
| getKeyRightOf(key: Key): Key { | ||
| return key; | ||
| } | ||
|
|
Member
Author
There was a problem hiding this comment.
Unnecessary now that useGridListItem handles left/right arrow keys presses in ListView rather than using useGridCell. Normal lists that use ListLayout won't have elements within their rows so they won't even use useGridCell
Would've written a test but didn't get accurate selectionStart returned by onKeyUp when triggering arrowleft/right (note: userEvent typing properly updated that). A updated version of user test library should fix this theoretically but that will require a greater refactor of our tests so I'll handle that later
|
Build successful! 🎉 |
snowystinger
approved these changes
Aug 19, 2022
Member
snowystinger
left a comment
snowystinger
left a comment
There was a problem hiding this comment.
Works as described in Chrome/Safari/Firefox
LFDanLu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3400
✅ Pull Request Checklist:
📝 Test Instructions:
Go to any combobox story and do the following:
🧢 Your Project:
RSP