Skip to content

Fix ComboBox left/right arrows so they move the input cursor when the menu is open #3415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LFDanLu merged 1 commit into from
Aug 19, 2022
Merged

Fix ComboBox left/right arrows so they move the input cursor when the menu is open #3415

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions packages/@react-stately/layout/src/ListLayout.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,14 +377,6 @@ export class ListLayout<T> extends Layout<Node<T>> implements KeyboardDelegate,
}
}

getKeyLeftOf(key: Key): Key {
return key;
}

getKeyRightOf(key: Key): Key {
return key;
}

Comment on lines -380 to -387
Copy link
Copy Markdown
Member Author

@LFDanLu LFDanLu Aug 19, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary now that useGridListItem handles left/right arrow keys presses in ListView rather than using useGridCell. Normal lists that use ListLayout won't have elements within their rows so they won't even use useGridCell

Would've written a test but didn't get accurate selectionStart returned by onKeyUp when triggering arrowleft/right (note: userEvent typing properly updated that). A updated version of user test library should fix this theoretically but that will require a greater refactor of our tests so I'll handle that later

getKeyPageAbove(key: Key) {
let layoutInfo = this.getLayoutInfo(key);

Expand Down