Provide defaults for TableColumnLayout if options aren't provided#3962
Merged
Conversation
|
Build successful! 🎉 |
snowystinger
approved these changes
Jan 30, 2023
Member
snowystinger
left a comment
There was a problem hiding this comment.
Looks right, covers both the hook and the TableLayout
|
Build successful! 🎉 |
|
## API Changes
unknown top level export { type: 'identifier', name: 'Column' } |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
Found when writing the aria table resizing component, currently crashes when
getDefaultWidth/getDefaultMinWidtharen't provided even though they are optional✅ Pull Request Checklist:
📝 Test Instructions:
Sanity test resizing examples. Otherwise the test should cover the case where the user doesn't actually provide any options (specifically
getDefaultWidthandgetDefaultMinWidth) to TableColumnLayout via useTableColumnResizeState🧢 Your Project:
RSP