You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After investigating this a bit more, I don't think this is a css specificity issue. It seemed that when the isDisabled prop was provided to<CheckboxGroup>, that value was not passed to the individual <Checkbox> components, resulting in the absence of the is-disabled class in their classnames. Therefore, if you wanted to the disabled styles to be applied to a selected checkbox in a checkbox group, you would also have to directly pass isDisabled to that specific checkbox.
Looking back at the commit history, it appears that this "broke" with this PR (#3827). However, if you go commit before it (which is #3962), you'll notice that the styling might be correct, but the is-disabled class still isn't a part of the classname even though it should be.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5378
After investigating this a bit more, I don't think this is a css specificity issue. It seemed that when the
isDisabledprop was provided to<CheckboxGroup>, that value was not passed to the individual<Checkbox>components, resulting in the absence of theis-disabledclass in their classnames. Therefore, if you wanted to the disabled styles to be applied to a selected checkbox in a checkbox group, you would also have to directly passisDisabledto that specific checkbox.Looking back at the commit history, it appears that this "broke" with this PR (#3827). However, if you go commit before it (which is #3962), you'll notice that the styling might be correct, but the
is-disabledclass still isn't a part of the classname even though it should be.✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: