Skip to content

Table column resizing aria docs#3982

Merged
LFDanLu merged 94 commits into
mainfrom
aria_table_docs
Apr 5, 2023
Merged

Table column resizing aria docs#3982
LFDanLu merged 94 commits into
mainfrom
aria_table_docs

Conversation

@LFDanLu
Copy link
Copy Markdown
Member

@LFDanLu LFDanLu commented Jan 31, 2023 •
edited
Loading

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Looks at the column resizing docs for useTableState and useTable. In addition, try the styled example out here: https://codesandbox.io/s/objective-cherry-g837on?file=/src/App.tsx

🧢 Your Project:

RSP

LFDanLu added 16 commits January 24, 2023 17:22
@LFDanLu
progress for making aria table resizing example
dde2ec2
@LFDanLu
styling updates and addition of menu button for resizing
1057b99
@LFDanLu
fixing it so user doesnt focus the resizer immediately when using lef…
dd43fa4 
…t/right arrows

still a bit iffy, cant seem to get focus to move between the columns, def something with the menutrigger...
@LFDanLu
making column resize actually get called if provided
82c93d3
@LFDanLu
fixing bugs, testing various cases, adding description to useTableCol…
9d16cdd 
…umnResizeState
@LFDanLu
Fix crash if onColumnResize is undef
f7693f1
@LFDanLu
figure out break
fa396c4
@LFDanLu
Merge branch 'main' of github.com:adobe/react-spectrum into aria_tabl…
620fbcb 
…e_docs
@LFDanLu
fix docs build break, add rest of code
d6673f7
@LFDanLu
fix docs example render issues
77d58ca
@LFDanLu
remove onColumnResize/Start/End from useTableColumnResizeState
5f6fb07 
these are unecessary since the state returns the resizing column already and we have onResize handlers in useTableColumnResize
@LFDanLu
Merge branch 'main' into fix_onColumnResize_call
4627c14
@LFDanLu
Merge branch 'fix_onColumnResize_call' of github.com:adobe/react-spec…
fb982c7 
…trum into aria_table_docs
@LFDanLu
docs first draft
9cb87b3
@LFDanLu
remove local test story for now
b4775ae
@LFDanLu
Merge branch 'main' into aria_table_docs
e89bf58
@rspbot
Copy link
Copy Markdown

rspbot commented Jan 31, 2023

Build successful! 🎉

LFDanLu
LFDanLu commented Jan 31, 2023
View reviewed changes
Comment thread packages/@react-aria/table/docs/useTable.mdx
LFDanLu
LFDanLu commented Jan 31, 2023
View reviewed changes
Comment thread packages/@react-aria/table/docs/useTable.mdx Outdated
@rspbot
Copy link
Copy Markdown

rspbot commented Jan 31, 2023

Build successful! 🎉

LFDanLu
LFDanLu commented Jan 31, 2023
View reviewed changes
Comment thread packages/@react-aria/table/docs/useTable.mdx Outdated
LFDanLu
LFDanLu commented Jan 31, 2023
View reviewed changes
Comment thread packages/@react-aria/table/docs/useTable.mdx Outdated
LFDanLu
LFDanLu commented Jan 31, 2023
View reviewed changes
Comment thread packages/@react-aria/table/docs/useTable.mdx Outdated
LFDanLu
LFDanLu commented Jan 31, 2023
View reviewed changes
Comment thread packages/@react-aria/table/docs/useTable.mdx Outdated
LFDanLu
LFDanLu commented Jan 31, 2023
View reviewed changes
Comment thread packages/@react-aria/table/docs/useTable.mdx Outdated
LFDanLu
LFDanLu commented Jan 31, 2023
View reviewed changes
Comment thread packages/@react-aria/table/docs/useTable.mdx Outdated
@rspbot
Copy link
Copy Markdown

rspbot commented Jan 31, 2023

Build successful! 🎉

LFDanLu
LFDanLu commented Jan 31, 2023
View reviewed changes
Comment thread packages/@react-stately/table/docs/useTableColumnResizeState.mdx Outdated
@rspbot

This comment was marked as outdated.

Sign in to view
@LFDanLu
Copy link
Copy Markdown
Member Author

LFDanLu commented Mar 31, 2023

TODO: update sandbox example so it uses input styles from useTableColumnResize hook instead of VisuallyHidden, need to wait for nightly/release for that

@rspbot
Copy link
Copy Markdown

rspbot commented Mar 31, 2023

Build successful! 🎉

@rspbot
Copy link
Copy Markdown

rspbot commented Mar 31, 2023

Build successful! 🎉

@rspbot
Copy link
Copy Markdown

rspbot commented Apr 5, 2023

Build successful! 🎉

snowystinger
snowystinger previously approved these changes Apr 5, 2023
View reviewed changes
@LFDanLu LFDanLu changed the title (DNM) Table column resizing aria docs Table column resizing aria docs Apr 5, 2023
@rspbot
Copy link
Copy Markdown

rspbot commented Apr 5, 2023

Build successful! 🎉

@rspbot
Copy link
Copy Markdown

rspbot commented Apr 5, 2023

Build successful! 🎉

@rspbot
Copy link
Copy Markdown

rspbot commented Apr 5, 2023

Build successful! 🎉

@rspbot
Copy link
Copy Markdown

rspbot commented Apr 5, 2023

Build successful! 🎉

@rspbot
Copy link
Copy Markdown

rspbot commented Apr 5, 2023

Build successful! 🎉

@rspbot
Copy link
Copy Markdown

rspbot commented Apr 5, 2023

## API Changes

unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }

@LFDanLu LFDanLu merged commit b06a446 into main Apr 5, 2023
@LFDanLu LFDanLu deleted the aria_table_docs branch April 5, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devongovett devongovett devongovett left review comments

@snowystinger snowystinger snowystinger approved these changes

@reidbarber reidbarber reidbarber approved these changes

Assignees

@snowystinger snowystinger

@LFDanLu LFDanLu

Labels

documentation Improvements or additions to documentation

Projects

RSP Component Milestones
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@LFDanLu @rspbot @devongovett @snowystinger @reidbarber