Skip to content

Table column resizing aria docs #3982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LFDanLu merged 94 commits into from
Apr 5, 2023
Merged

Table column resizing aria docs #3982

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
94 commits
Select commit Hold shift + click to select a range
dde2ec2
progress for making aria table resizing example
LFDanLu Jan 25, 2023
1057b99
styling updates and addition of menu button for resizing
LFDanLu Jan 26, 2023
dd43fa4
fixing it so user doesnt focus the resizer immediately when using lef…
LFDanLu Jan 27, 2023
82c93d3
making column resize actually get called if provided
LFDanLu Jan 27, 2023
9d16cdd
fixing bugs, testing various cases, adding description to useTableCol…
LFDanLu Jan 27, 2023
f7693f1
Fix crash if onColumnResize is undef
LFDanLu Jan 27, 2023
fa396c4
figure out break
LFDanLu Jan 28, 2023
620fbcb
Merge branch 'main' of github.com:adobe/react-spectrum into aria_tabl…
LFDanLu Jan 28, 2023
d6673f7
fix docs build break, add rest of code
LFDanLu Jan 28, 2023
77d58ca
fix docs example render issues
LFDanLu Jan 30, 2023
5f6fb07
remove onColumnResize/Start/End from useTableColumnResizeState
LFDanLu Jan 30, 2023
4627c14
Merge branch 'main' into fix_onColumnResize_call
LFDanLu Jan 30, 2023
fb982c7
Merge branch 'fix_onColumnResize_call' of github.com:adobe/react-spec…
LFDanLu Jan 30, 2023
9cb87b3
docs first draft
LFDanLu Jan 31, 2023
b4775ae
remove local test story for now
LFDanLu Jan 31, 2023
e89bf58
Merge branch 'main' into aria_table_docs
LFDanLu Jan 31, 2023
799c107
small cleanup
LFDanLu Jan 31, 2023
dd7936a
Merge branch 'aria_table_docs' of github.com:adobe/react-spectrum int…
LFDanLu Jan 31, 2023
da23015
updating resizer in docs
LFDanLu Jan 31, 2023
e2ccf0d
fixing talkback and Safari aria resizer focus issues
LFDanLu Jan 31, 2023
28b5bd0
fixing checkbox rendering in iOS Safari
LFDanLu Jan 31, 2023
75abc83
Merge branch 'main' of github.com:adobe/react-spectrum into aria_tabl…
LFDanLu Jan 31, 2023
cdd97e1
editing/proofreading
LFDanLu Jan 31, 2023
2d7b441
move useTableColumnResizeState to useTableState docs
LFDanLu Feb 3, 2023
7697f24
Merge branch 'main' of github.com:adobe/react-spectrum into aria_tabl…
LFDanLu Feb 3, 2023
dc889ef
moving resizable table section and addressing smaller changes
LFDanLu Feb 3, 2023
ff526ba
simplifying example
LFDanLu Feb 4, 2023
ef23f53
collapsing some parts of the code and trying to display the code bloc…
LFDanLu Feb 4, 2023
4243cd7
addressing review comments
LFDanLu Feb 6, 2023
dfdc4cd
add tailwind example
LFDanLu Feb 7, 2023
8dfce34
forgot to add some additional comments
LFDanLu Feb 7, 2023
bd405cf
override native focus ring for button
LFDanLu Feb 7, 2023
7e7b117
update copy as per review and re-collapse code blocks
LFDanLu Feb 7, 2023
e7bad62
Merge branch 'main' into aria_table_docs
snowystinger Feb 7, 2023
312def9
uncollapsing code blocks
LFDanLu Feb 9, 2023
128edfa
Rough example of press header to start resizing
LFDanLu Feb 14, 2023
63ad571
Merge branch 'main' of github.com:adobe/react-spectrum into aria_tabl…
LFDanLu Feb 14, 2023
02c2487
Updating column resize to support mode where resizer is always visible
LFDanLu Feb 16, 2023
a00fa21
update to match latest changes to api
LFDanLu Feb 16, 2023
c270a5a
mimic docs example
LFDanLu Feb 16, 2023
f6a3d07
forgot to clean up some things
LFDanLu Feb 16, 2023
77854cf
Merge branch 'main' of github.com:adobe/react-spectrum into aria_tabl…
LFDanLu Feb 17, 2023
603f191
Merge branch 'updates_to_column_resizing' of github.com:adobe/react-s…
LFDanLu Feb 17, 2023
cc62d52
pulling in code changes from docs PR
LFDanLu Feb 17, 2023
7353190
Add separate mode for triggering resizing manually via Enter (#4061)
LFDanLu Feb 17, 2023
caefaf7
remove sorting story and cleanup
LFDanLu Feb 17, 2023
01f2d31
starting resize on press for indicator
LFDanLu Feb 17, 2023
5daa07a
using triggerRef existance to determine if behavior is resize on focus
LFDanLu Feb 17, 2023
9834b8b
fixing test
LFDanLu Feb 17, 2023
d84ac1d
make resizer single line for focus
LFDanLu Feb 17, 2023
460bb5f
Merge branch 'main' into updates_to_column_resizing
LFDanLu Feb 17, 2023
935fe4a
nit reorganizing
LFDanLu Feb 17, 2023
8c85bd1
Merge branch 'updates_to_column_resizing' of github.com:adobe/react-s…
LFDanLu Feb 17, 2023
9980718
Merge branch 'updates_to_column_resizing' of github.com:adobe/react-s…
LFDanLu Feb 17, 2023
e028867
update docs example for resizer styling
LFDanLu Feb 17, 2023
5a6741c
mimic docs example
LFDanLu Feb 17, 2023
7b8aaf4
adding description for keyboard users for Enter to start resizing
LFDanLu Feb 17, 2023
1f4213f
fixing issue where tab wasnt exiting the table when focused on the re…
LFDanLu Feb 17, 2023
2bc566f
adding min width for columns to avoid weirdness with trying to collap…
LFDanLu Feb 17, 2023
54b7327
fix lint
LFDanLu Feb 17, 2023
af4932d
Merge branch 'updates_to_column_resizing' of github.com:adobe/react-s…
LFDanLu Feb 17, 2023
ff56eab
avoid weirdness with width 0 by setting a min width
LFDanLu Feb 17, 2023
dc7aaa6
propagate all keydown events if we arent in resize mode and have alwa…
LFDanLu Feb 18, 2023
c2a8a7f
removing ref read in render
LFDanLu Feb 18, 2023
e1b1abf
add aria description to input for virtual modality too
LFDanLu Feb 28, 2023
cf63a95
addressing review comments
LFDanLu Mar 1, 2023
3503d2e
Merge branch 'main' of github.com:adobe/react-spectrum into updates_t…
LFDanLu Mar 1, 2023
201a9aa
Merge branch 'updates_to_column_resizing' of github.com:adobe/react-s…
LFDanLu Mar 1, 2023
d9fce45
fix some copy
LFDanLu Mar 1, 2023
f44068d
prevent extraneous scrolling when keyboard navigating to the resizer
LFDanLu Mar 1, 2023
6e378f9
Merge branch 'updates_to_column_resizing' of github.com:adobe/react-s…
LFDanLu Mar 1, 2023
982b3ad
fixing extraneous scrolling behavior
LFDanLu Mar 1, 2023
60a66c5
address review comments
LFDanLu Mar 3, 2023
b228c3a
fix logic
LFDanLu Mar 3, 2023
605bd5f
Merge branch 'main' into updates_to_column_resizing
LFDanLu Mar 3, 2023
655f178
Merge branch 'updates_to_column_resizing' of github.com:adobe/react-s…
LFDanLu Mar 3, 2023
00f3ff1
removing margin style in favor of hook provided style
LFDanLu Mar 3, 2023
efd3613
Merge branch 'main' of github.com:adobe/react-spectrum into aria_tabl…
LFDanLu Mar 20, 2023
b7e4dc8
fix typescript lint
LFDanLu Mar 20, 2023
97b5b7b
make resize handle larger
LFDanLu Mar 20, 2023
31c070a
fix resizer style on drag
LFDanLu Mar 21, 2023
71f1909
Merge branch 'main' into aria_table_docs
LFDanLu Mar 21, 2023
6c17a72
Simplify aria table resizing docs example (#4253)
devongovett Mar 23, 2023
6afbcc0
Merge branch 'main' into aria_table_docs
devongovett Mar 23, 2023
c80d298
update example to match updated hooks
LFDanLu Mar 23, 2023
088a5c0
Merge branch 'main' into aria_table_docs
LFDanLu Mar 31, 2023
9a0791c
remove VisuallyHidden from resizer in favor of styles from hook
LFDanLu Mar 31, 2023
22a6952
Merge branch 'main' into aria_table_docs
LFDanLu Apr 5, 2023
c5dd6bb
Merge branch 'main' into aria_table_docs
snowystinger Apr 5, 2023
b55b13d
Merge branch 'main' into aria_table_docs
LFDanLu Apr 5, 2023
79a1ac6
Merge branch 'main' into aria_table_docs
LFDanLu Apr 5, 2023
c9025ed
adding version badge
LFDanLu Apr 5, 2023
c7d35a8
Merge branch 'aria_table_docs' of github.com:adobe/react-spectrum int…
LFDanLu Apr 5, 2023
f4d511e
Merge branch 'main' into aria_table_docs
LFDanLu Apr 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added packages/@react-aria/table/docs/Table-tailwind.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading