fix(statuslight): remove accent variant tokens by marissahuysentruyt · Pull Request #3561 · adobe/spectrum-css

marissahuysentruyt · 2025-02-17T14:04:26Z

Description

This PR addresses the TODO to remove the accent variant of the status light. The accent variant is not supported in S2, so all references in the documentation, tests and CSS should be removed now.

removes --spectrum-statuslight-semantic-accent-color from CSS
removes deprecated accent variant from template and tests

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

Pull down the branch to run locally or visit the deploy preview
Visit the status light docs page.
Verify that the accent status light has been removed from the "Semantic" story canvas

Visit the status light testing preview
Verify the accent status light is not present as any of the test cases.

Additional validation

Searching the repo for --spectrum-statuslight-semantic-accent-color results in nothing being found
Searching the repo for .spectrum-StatusLight--accent results in nothing being found

Regression testing

Validate:

The documentation pages for at least two other components are still loading, including:

The pages render correctly, are accessible, and are responsive.

If components have been modified, VRTs have been run on this branch:

VRTs have been run and looked at.
Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

Before 🚫

After ✅

To-do list

I have read the contribution guidelines.
I have updated relevant storybook stories and templates.
I have tested these changes in Windows High Contrast mode.
If my change impacts other components, I have tested to make sure they don't break.
If my change impacts documentation, I have updated the documentation accordingly.
✨ This pull request is ready to merge. ✨

changeset-bot · 2025-02-17T14:04:32Z

🦋 Changeset detected

Latest commit: e16cdea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@spectrum-css/statuslight	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2025-02-17T14:08:55Z

File metrics

Summary

Total size: 1.42 MB^*
Total change (Δ): 🟢 ⬇ 0.08 KB (-0.01%)

Table reports on changes to a package's main file.

Package	Size	Minified	Gzipped	Δ
statuslight	12.37 KB	-	-	🟢 ⬇ 0.08 KB

statuslight

Filename	Head	Minified	Gzipped	Compared to base
index.css	12.37 KB	-	-	🟢 ⬇ 0.08 KB
metadata.json	7.95 KB	-	-	🟢 ⬇ 0.09 KB

* Size is the sum of all main files for packages in the library.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

github-actions · 2025-02-17T14:10:07Z

🚀 Deployed on https://pr-3561--spectrum-css.netlify.app

marissahuysentruyt · 2025-02-17T16:07:13Z


 	/* Dot */
 	&::before {
+		--spectrum-statuslight-spacing-computed-top-to-dot: calc(var(--mod-statuslight-spacing-top-to-dot, var(--spectrum-statuslight-spacing-top-to-dot)) - var(--mod-statuslight-spacing-top-to-label, var(--spectrum-statuslight-spacing-top-to-label)));


I think this must have been a linter fix- I didn't intentionally move this and didn't see it until the PR was created.

marissahuysentruyt · 2025-02-17T16:07:18Z

-		forced-color-adjust: none;
 		--highcontrast-statuslight-content-color-default: CanvasText;
 		--highcontrast-statuslight-subdued-content-color-default: CanvasText;
+		forced-color-adjust: none;


Same here- I think this must have been a linter fix.

marissahuysentruyt · 2025-02-17T16:10:42Z

 	</div>
 `;

-// TODO: the accent variant will be removed in S2.


I put this TODO in main during the status light docs migration, but during the S2 status light migration I had removed the accent variant already.

- removes --spectrum-statuslight-semantic-accent-color from CSS - removes deprecated accent variant from template and tests - adds changeset - update metadata.json

marissahuysentruyt self-assigned this Feb 17, 2025

marissahuysentruyt added size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day. S2 Spectrum 2 labels Feb 17, 2025

marissahuysentruyt commented Feb 17, 2025

View reviewed changes

marissahuysentruyt marked this pull request as ready for review February 17, 2025 16:10

marissahuysentruyt added the skip_vrt Add to a PR to skip running VRT (but still pass the action) label Feb 17, 2025

marissahuysentruyt force-pushed the marissahuysentruyt/s2-status-light-remove-accent-variant branch from 22895c0 to 5456dad Compare February 17, 2025 16:12

marissahuysentruyt added the ready-for-review label Feb 17, 2025

jawinn approved these changes Feb 17, 2025

View reviewed changes

fix(statuslight): remove accent variant

e16cdea

- removes --spectrum-statuslight-semantic-accent-color from CSS - removes deprecated accent variant from template and tests - adds changeset - update metadata.json

marissahuysentruyt force-pushed the marissahuysentruyt/s2-status-light-remove-accent-variant branch from 34122ea to e16cdea Compare February 17, 2025 21:46

marissahuysentruyt merged commit 2637aa6 into spectrum-two Feb 17, 2025

marissahuysentruyt deleted the marissahuysentruyt/s2-status-light-remove-accent-variant branch February 17, 2025 21:55

castastrophe mentioned this pull request Apr 15, 2025

feat(tokens,card): update to @adobe/spectrum-tokens@13.3.0 #3669

Merged

12 tasks

This was referenced May 16, 2025

chore(swatch,menu,swatchgroup): fix reverted metadata assets #3752

Merged

chore: merge latest updates from main #3777

Merged

castastrophe mentioned this pull request Jul 25, 2025

ci: chromatic runs for S2 [CSS-1233] #4070

Merged

3 tasks

castastrophe mentioned this pull request Aug 6, 2025

fix: minor linting updates #4113

Merged

11 tasks

This was referenced Aug 27, 2025

chore(popover): wrapper placement in story #4173

Closed

feat(storybook): chromatic a11y testing #4180

Closed

chore: updating lint-staged file inheritance order #4193

Closed

castastrophe mentioned this pull request Oct 22, 2025

feat(badge): remove modifiers from the API [SWC-1264] #4283

Merged

14 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(statuslight): remove accent variant tokens#3561

fix(statuslight): remove accent variant tokens#3561
marissahuysentruyt merged 1 commit into
spectrum-twofrom
marissahuysentruyt/s2-status-light-remove-accent-variant

marissahuysentruyt commented Feb 17, 2025 •

edited by jawinn

Loading

Uh oh!

changeset-bot Bot commented Feb 17, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Feb 17, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Feb 17, 2025 •

edited

Loading

Uh oh!

marissahuysentruyt Feb 17, 2025

Uh oh!

marissahuysentruyt Feb 17, 2025

Uh oh!

marissahuysentruyt Feb 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

marissahuysentruyt commented Feb 17, 2025 • edited by jawinn Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How and where has this been tested?

Validation steps

Additional validation

Regression testing

Screenshots

To-do list

Uh oh!

changeset-bot Bot commented Feb 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions Bot commented Feb 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

File metrics

Summary

statuslight

Uh oh!

github-actions Bot commented Feb 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marissahuysentruyt Feb 17, 2025

Choose a reason for hiding this comment

Uh oh!

marissahuysentruyt Feb 17, 2025

Choose a reason for hiding this comment

Uh oh!

marissahuysentruyt Feb 17, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

marissahuysentruyt commented Feb 17, 2025 •

edited by jawinn

Loading

changeset-bot Bot commented Feb 17, 2025 •

edited

Loading

github-actions Bot commented Feb 17, 2025 •

edited

Loading

github-actions Bot commented Feb 17, 2025 •

edited

Loading