Skip to content

fix(statuslight): remove accent variant tokens #3561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marissahuysentruyt merged 1 commit into from
Feb 17, 2025
Merged

fix(statuslight): remove accent variant tokens #3561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .changeset/small-impalas-search.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
---
"@spectrum-css/statuslight": patch
---

Removes references to the accent variant, since the accent status light was deprecated in S2.

Removed variant:

`.spectrum-StatusLight--accent`
`--spectrum-statuslight-semantic-accent-color`
2 changes: 0 additions & 2 deletions components/statuslight/dist/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,6 @@
"--spectrum-statuslight-nonsemantic-silver-color",
"--spectrum-statuslight-nonsemantic-turquoise-color",
"--spectrum-statuslight-nonsemantic-yellow-color",
"--spectrum-statuslight-semantic-accent-color",
"--spectrum-statuslight-semantic-info-color",
"--spectrum-statuslight-semantic-negative-color",
"--spectrum-statuslight-semantic-neutral-color",
Expand All @@ -134,7 +133,6 @@
"--spectrum-statuslight-subdued-content-color-default"
],
"global": [
"--spectrum-accent-visual-color",
"--spectrum-blue-visual-color",
"--spectrum-border-width-100",
"--spectrum-brown-visual-color",
Expand Down
6 changes: 2 additions & 4 deletions components/statuslight/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,6 @@
--spectrum-statuslight-content-color-default: var(--spectrum-neutral-content-color-default);
--spectrum-statuslight-subdued-content-color-default: var(--spectrum-neutral-subdued-content-color-default);
--spectrum-statuslight-semantic-neutral-color: var(--spectrum-neutral-visual-color);
--spectrum-statuslight-semantic-accent-color: var(--spectrum-accent-visual-color);
--spectrum-statuslight-semantic-negative-color: var(--spectrum-negative-visual-color);
--spectrum-statuslight-semantic-info-color: var(--spectrum-informative-visual-color);
--spectrum-statuslight-semantic-notice-color: var(--spectrum-notice-visual-color);
Expand Down Expand Up @@ -159,15 +158,14 @@

/* Dot */
&::before {
--spectrum-statuslight-spacing-computed-top-to-dot: calc(var(--mod-statuslight-spacing-top-to-dot, var(--spectrum-statuslight-spacing-top-to-dot)) - var(--mod-statuslight-spacing-top-to-label, var(--spectrum-statuslight-spacing-top-to-label)));
Copy link
Copy Markdown
Collaborator Author

@marissahuysentruyt marissahuysentruyt Feb 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this must have been a linter fix- I didn't intentionally move this and didn't see it until the PR was created.

content: "";
flex-grow: 0;
flex-shrink: 0;
display: inline-block;
inline-size: var(--mod-statuslight-dot-size, var(--spectrum-statuslight-dot-size));
block-size: var(--mod-statuslight-dot-size, var(--spectrum-statuslight-dot-size));
border-radius: var(--mod-statuslight-corner-radius, var(--spectrum-statuslight-corner-radius));

--spectrum-statuslight-spacing-computed-top-to-dot: calc(var(--mod-statuslight-spacing-top-to-dot, var(--spectrum-statuslight-spacing-top-to-dot)) - var(--mod-statuslight-spacing-top-to-label, var(--spectrum-statuslight-spacing-top-to-label)));
margin-block-start: var(--spectrum-statuslight-spacing-computed-top-to-dot);
margin-inline-end: var(--mod-statuslight-spacing-dot-to-label, var(--spectrum-statuslight-spacing-dot-to-label));
}
Expand Down Expand Up @@ -277,9 +275,9 @@

@media (forced-colors: active) {
.spectrum-StatusLight {
forced-color-adjust: none;
--highcontrast-statuslight-content-color-default: CanvasText;
--highcontrast-statuslight-subdued-content-color-default: CanvasText;
forced-color-adjust: none;
Copy link
Copy Markdown
Collaborator Author

@marissahuysentruyt marissahuysentruyt Feb 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here- I think this must have been a linter fix.


/* Dot */
&::before {
Expand Down
2 changes: 1 addition & 1 deletion components/statuslight/stories/statuslight.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { Template } from "./template.js";
export const StatusLightGroup = Variants({
Template,
testData: [
...["accent", "info", "positive", "negative", "notice", "neutral"].map((variant) => ({
...["info", "positive", "negative", "notice", "neutral"].map((variant) => ({
testHeading: variant.charAt(0).toUpperCase() + variant.slice(1),
variant,
})),
Expand Down
2 changes: 0 additions & 2 deletions components/statuslight/stories/template.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,10 @@ export const Template = ({
</div>
`;

// TODO: the accent variant will be removed in S2.
Copy link
Copy Markdown
Collaborator Author

@marissahuysentruyt marissahuysentruyt Feb 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put this TODO in main during the status light docs migration, but during the S2 status light migration I had removed the accent variant already.

export const SemanticGroup = (args, context) => Container({
withBorder: false,
direction: "column",
content: html`${[
"accent",
"neutral",
"info",
"negative",
Expand Down