Skip to content

docs: adds tag for migrated components#3688

Merged
castastrophe merged 2 commits into
spectrum-twofrom
marissahuysentruyt/docs-add-migrated-tags
May 5, 2025
Merged

docs: adds tag for migrated components#3688
castastrophe merged 2 commits into
spectrum-twofrom
marissahuysentruyt/docs-add-migrated-tags

Conversation

@marissahuysentruyt
Copy link
Copy Markdown
Collaborator

@marissahuysentruyt marissahuysentruyt commented May 2, 2025

Description

Some of our migrated components from 2024 (like textfield, search, switch, button, etc), had the migrated tag added to the components' metadata. You could find tags: ["migrated"] in the story files. However, at some point we stopped adding that tag, and because we've gotten back to migrated S2 components, it would probably be good to add this tag to all of our currently migrated components.

This work adds that migrated tag to the components that are missing it as of 5 May 2025.

Jira

CSS-1191 (ticket for this work)
CSS-604 (epic for S2 Migration)

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

  • Pull down the branch to be able search.
  • Search for tags: ["migrated"] in the repo. You should get 45 components returned 🥳
  • Compare the results to the list in the S2 Migration epic. All components found during your search should have an associated ticket, EXCEPT FOR:
    • The progress bar ticket looks like it's missing from the epic, but it was migrated here: feat(progressbar): s2 migration #2659 👍
    • The status light ticket looks like it's missing from the epic, but it was migrated here: feat(statuslight): s2 migration #2818 👍
    • The switch ticket looks like it's missing from the epic, but it was migrated here: feat(switch): s2 migration #2651 👍
    • The dial component is marked as migrated, but I believe this is a "one-off" component. There are no designs. 👍
    • The field group component is marked as migrated, probably because that component is just collections of checkboxes and collections of radios (both of which have been migrated). 👍
    • The form component is marked as migrated for a similar reason. All nested components in the form, aside from number field (which is in-progress), have been migrated. 👍
    • Pagination is marked as migrated for a similar reason. All nested components have been migrated. 👍

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • VRTs have been run and looked at.
  • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

To-do list

  • I have read the contribution guidelines.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 2, 2025

⚠️ No Changeset found

Latest commit: 90e521f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 2, 2025

File metrics

Summary

Total size: 1.38 MB*

🎉 No changes detected in any packages

* Size is the sum of all main files for packages in the library.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 2, 2025

🚀 Deployed on https://pr-3688--spectrum-css.netlify.app

@marissahuysentruyt marissahuysentruyt self-assigned this May 2, 2025
@marissahuysentruyt marissahuysentruyt added size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day. S2 Spectrum 2 labels May 5, 2025
@marissahuysentruyt marissahuysentruyt marked this pull request as ready for review May 5, 2025 15:56
packageJson,
metadata,
},
tags: ["migrated"],
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meter isn't quite migrated. We are missing a new S2 size.

@marissahuysentruyt marissahuysentruyt force-pushed the marissahuysentruyt/docs-add-migrated-tags branch from 0f3e43e to b3a5550 Compare May 5, 2025 16:23
@castastrophe castastrophe enabled auto-merge (squash) May 5, 2025 20:19
@castastrophe castastrophe merged commit f42cf88 into spectrum-two May 5, 2025
17 of 24 checks passed
@castastrophe castastrophe deleted the marissahuysentruyt/docs-add-migrated-tags branch May 5, 2025 20:24
@marissahuysentruyt marissahuysentruyt restored the marissahuysentruyt/docs-add-migrated-tags branch May 6, 2025 15:12
@marissahuysentruyt marissahuysentruyt deleted the marissahuysentruyt/docs-add-migrated-tags branch May 6, 2025 15:13
@marissahuysentruyt marissahuysentruyt mentioned this pull request May 6, 2025
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-review S2 Spectrum 2 size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants