feat(statuslight): s2 migration

[marissahuysentruyt]

Description

This migrates the Status light to S2. 🎉 New color tokens and text-to-visual tokens were added to match the design specs. The neutral variant label uses default-font-family instead of italic, and the semantic accent variant has been removed, both according to design specs.

This PR also increases Chromatic coverage for Status light variants.

Designs

S2 Tokens specs
S2 / Desktop

• New mods:

  • --mod-statuslight-font-family
  • --mod-statuslight-font-style
  • --mod-statuslight-nonsemantic-brown-color
  • --mod-statuslight-nonsemantic-cinnamon-color
  • --mod-statuslight-nonsemantic-pink-color
  • --mod-statuslight-nonsemantic-silver-color
  • --mod-statuslight-nonsemantic-turquoise-color

• Removed mods:

  • --mod-statuslight-semantic-accent-color

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

• Design review and approval (@marissahuysentruyt and Amun)
• Status light matches S2 designs
• Removed elements include:
  • no accent variant
  • the neutral variant's label no longer uses italics
• New tokens are used:
  • --spectrum-status-light-text-to-visual-75
  • --spectrum-status-light-text-to-visual-100
  • --spectrum-status-light-text-to-visual-200
  • --spectrum-status-light-text-to-visual-300
  • --spectrum-pink-visual-color
  • --spectrum-turquoise-visual-color
  • --spectrum-cinnamon-visual-color
  • --spectrum-brown-visual-color
  • --spectrum-silver-visual-color
• Updated tokens are used:
  • --spectrum-status-light-top-to-dot-small
  • --spectrum-status-light-top-to-dot-medium
  • --spectrum-status-light-top-to-dot-large
  • --spectrum-status-light-top-to-dot-extra-large
  • --spectrum-status-light-dot-size-small
  • --spectrum-status-light-dot-size-medium
  • --spectrum-status-light-dot-size-large
  • --spectrum-status-light-dot-size-extra-large
• Verify the accent variant has been removed from the "variant" controls dropdown
• Verify the new non-semantic colors appear in the "variant controls dropdown
• Verify the semantic neutral variant's label color now uses --spectrum-gray-600
• Verify variants use new custom properties to utilize font tokens:
  • --spectrum-statuslight-font-family: var(--spectrum-default-font-family);
  • --spectrum-statuslight-font-weight: var(--spectrum-regular-font-weight);
  • --spectrum-statuslight-font-style: var(--spectrum-default-font-style);
• In your code editor, ensure the --sizeM class has been deleted from the status light index.css file
• Verify Chromatic coverage (using the testing preview) includes all 5 semantic variants, 14 non-semantic variants, and the 4 t-shirt sizes. The size variants should also include an example of wrapping labels.

Regression testing

Validate:

1. The documentation pages for at least two other components are still loading, including:

• The pages render correctly, are accessible, and are responsive.

2. If components have been modified, VRTs have been run on this branch:

• VRTs have been run and looked at.
• Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

To-do list

• I have read the contribution guidelines.
• I have updated relevant storybook stories and templates.
• I have tested these changes in Windows High Contrast mode.
• If my change impacts other components, I have tested to make sure they don't break.
• If my change impacts documentation, I have updated the documentation accordingly.
• ✨ This pull request is ready to merge. ✨

[changeset-bot]

🦋 Changeset detected

Latest commit: a11ab69

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@spectrum-css/statuslight	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

🚀 Deployed on https://pr-2818--spectrum-css.netlify.app

[github-actions]

File metrics

Summary

Total size: 4.23 MB^*
Total change (Δ): ⬆ 3.30 KB (0.08%)

Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.

Package	Size	Δ
statuslight	12.25 KB	⬆ 0.77 KB

Details

statuslight

File	Head	Base	Δ
index-base.css	12.25 KB	11.49 KB	⬆ 0.77 KB (6.58%)
index-vars.css	12.25 KB	11.49 KB	⬆ 0.77 KB (6.58%)
index.css	12.25 KB	11.49 KB	⬆ 0.77 KB (6.58%)
metadata.json	7.82 KB	6.79 KB	⬆ 1.03 KB (15.17%)

* Size determined by adding together the size of the main file for all packages in the library.
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

[jawinn]

This is looking really good! Nice work on the Chromatic-only templates for Storybook too.

[rise-erpelding]

This is looking really good! I see you've already made the changes Josh requested and the only other thing I would add is that you can add the changeset to this PR!

[rise-erpelding]

This looks ready as far as I'm concerned! Nice work!

[jawinn]

Looks good! You've addressed all my comments.

One thing I would suggest bringing up with the designers during design validation is that "Height" should be labeled "Minimum Height" on the Figma; and showing text wrapping on there would be a good idea too.