docs: add storybook migrated badge#3690
Conversation
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
eslint
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 2 tabs but found 4 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 2 tabs but found 4 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 2 tabs but found 4 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 2 tabs but found 4 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 2 tabs but found 4 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 2 tabs but found 4 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 2 tabs but found 4 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 2 tabs but found 4 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 2 tabs but found 4 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 2 tabs but found 4 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 2 tabs but found 4 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 2 tabs but found 4 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 2 tabs but found 4 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 2 tabs but found 4 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 2 tabs but found 4 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 2 tabs but found 4 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 2 tabs but found 4 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 2 tabs but found 4 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 2 tabs but found 4 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 2 tabs but found 4 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 2 tabs but found 4 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 2 tabs but found 4 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 2 tabs but found 4 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 2 tabs but found 4 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 2 tabs but found 4 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 2 tabs but found 4 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 2 tabs but found 4 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 2 tabs but found 4 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 2 tabs but found 4 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 2 tabs but found 4 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 2 tabs but found 4 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 2 tabs but found 4 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 2 tabs but found 4 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 2 tabs but found 4 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 2 tabs but found 4 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 1 tab but found 2 spaces.
Expected indentation of 2 tabs but found 4 spaces.
Expected indentation of 1 tab but found 2 spaces.
File metricsSummaryTotal size: 1.38 MB* 🎉 No changes detected in any packages * Size is the sum of all main files for packages in the library.* An ASCII character in UTF-8 is 8 bits or 1 byte. |
|
🚀 Deployed on https://pr-3690--spectrum-css.netlify.app |
marissahuysentruyt
force-pushed
the
marissahuysentruyt/css-1192-add-storybook-migrated-badge
branch
2 times, most recently
from
6117bc3 to
cfd5ecd
Compare
| description: "Should not be used and will not receive updates.", | ||
| }, | ||
| migrated: { | ||
| background: "rgb(84, 36, 219)", |
There was a problem hiding this comment.
I have the rgb for indigo-1100 in light mode. We could forseeably use tokens for the background & font color, but I saw we didn't do that with the deprecated status, so I elected not to do that for migrated.
There was a problem hiding this comment.
Yeah I think I tried once and there was a type-check in place for the tool so it throws an error.
| CoachmarkMenuStatesTemplate, | ||
| CoachMarkMediaOptionsTemplate, | ||
| CoachmarkMenuStatesTemplate, | ||
| Template, |
There was a problem hiding this comment.
My linter keeps correcting these.
There was a problem hiding this comment.
Ah yes, alphabetical sorting is in our linting system I think.
| @@ -1,6 +1,6 @@ | |||
| import { Sizes } from "@spectrum-css/preview/decorators"; | |||
There was a problem hiding this comment.
Another linting pick up, I guess?
castastrophe
left a comment
castastrophe
left a comment
There was a problem hiding this comment.
YAY I'm so excited for this update! I can re-review when it's ready. 💃
| description: "Should not be used and will not receive updates.", | ||
| }, | ||
| migrated: { | ||
| background: "rgb(84, 36, 219)", |
There was a problem hiding this comment.
Yeah I think I tried once and there was a type-check in place for the tool so it throws an error.
| CoachmarkMenuStatesTemplate, | ||
| CoachMarkMediaOptionsTemplate, | ||
| CoachmarkMenuStatesTemplate, | ||
| Template, |
There was a problem hiding this comment.
Ah yes, alphabetical sorting is in our linting system I think.
marissahuysentruyt
force-pushed
the
marissahuysentruyt/css-1192-add-storybook-migrated-badge
branch
from
cfd5ecd to
5e7c3a6
Compare
marissahuysentruyt
added
size-2 S
marissahuysentruyt
force-pushed
the
marissahuysentruyt/css-1192-add-storybook-migrated-badge
branch
from
5e7c3a6 to
ca23f1d
Compare
Adds the migrated status to components that have been migrated fully to S2. A migrated badge to the storybook toolbar should now appear for those components.
castastrophe
force-pushed
the
marissahuysentruyt/css-1192-add-storybook-migrated-badge
branch
from
ca23f1d to
b033f69
Compare
castastrophe
deleted the
marissahuysentruyt/css-1192-add-storybook-migrated-badge
branch
2 participants
Description
This work adds the "migrated" status to S2 migrated components. A new indigo badge should appear on component pages for a S2-migrated components. 🥳 This will be really nice to have once
spectrum-twohas merged into ourmainbranch, especially if not all components have been migrated!Jira/Specs
CSS-1192
CSS-604 (epic for S2 Migration)
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
status: { type: "migrated" }parameter has been added to each S2 migrated component, according to the list in the S2 Migration epic. All components have an associated ticket, EXCEPT FOR:parametersobject in the component's CSF, add:Regression testing
Validate:
Screenshots
To-do list