fix: prevent terminal cursor from disappearing after breaking change …

[pec1985]

…error by returning error instead of os.Exit(1) in checkForBreakingChanges

We can't just quit in the middle of a UI process, we need to gracefully quit after cleaning up. Please dont call panic or os.Exit when we're in a UI session

Summary by CodeRabbit

• Refactor
  • Improved error handling by returning errors instead of immediately terminating the process when breaking changes or migrations are detected. This allows for better control and flexibility in managing such scenarios.

[coderabbitai]

Walkthrough

The function checkForBreakingChanges in the internal bundler logic was updated to eliminate direct process termination using os.Exit(1). Instead, the function now returns formatted errors in all cases where it previously exited, allowing callers to handle errors appropriately rather than terminating the process immediately.

Changes

File(s)	Change Summary
internal/bundler/upgrade.go	Replaced all os.Exit(1) calls in checkForBreakingChanges with error returns and error messages.

Poem

A hop, a skip, no more abrupt ends,
Now errors return where exit once sends.
The code flows on, with grace it proceeds,
Letting callers decide the next steps and needs.
A gentle change, a softer route—
This bunny approves, without a doubt! 🐇

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

internal/bundler/upgrade.go (2)

75-75: Fix trailing space in version constraint.

There's a trailing space in the version constraint that could potentially cause semver parsing issues.

-		Version: "<0.0.115 ",
+		Version: "<0.0.115",

---

77-77: Fix typo in migration message.

There's a typo "aand" in the migration message.

-		Message: "The environment variable and code reference for your Agentuity API key has changed from AGENTUITY_API_KEY to AGENTUITY_SDK_KEY. Update all occurrences in your .env files and codebase. See the v0.0.115 Changelog for details.\n\n" + tui.Link("https://agentuity.dev/Changelog/sdk-js#v00115") + "\n\nAfter migrated, please run npm upgrade @agentuity/sdk aand then re-run this command again.",
+		Message: "The environment variable and code reference for your Agentuity API key has changed from AGENTUITY_API_KEY to AGENTUITY_SDK_KEY. Update all occurrences in your .env files and codebase. See the v0.0.115 Changelog for details.\n\n" + tui.Link("https://agentuity.dev/Changelog/sdk-js#v00115") + "\n\nAfter migrated, please run npm upgrade @agentuity/sdk and then re-run this command again.",

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c6ea863 and 4e677fb.

📒 Files selected for processing (1)

• internal/bundler/upgrade.go (1 hunks)

🔇 Additional comments (3)

internal/bundler/upgrade.go (3)

243-243: LGTM! Good improvement for graceful error handling.

The change from os.Exit(1) to returning an error after successful migration allows the caller to handle cleanup properly, which aligns perfectly with the PR objective to prevent terminal cursor disappearance.

---

250-250: LGTM! Consistent error handling approach.

Replacing the immediate exit with error return maintains consistency with the function's error handling pattern and allows proper UI cleanup.

---

252-252: LGTM! Proper replacement of logger.Fatal.

Converting the fatal log call to error return is the correct approach, ensuring the caller can handle the error gracefully instead of abruptly terminating.