Skip to content

fix: prevent terminal cursor from disappearing after breaking change … #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pec1985 merged 1 commit into from
Jun 2, 2025
Merged

fix: prevent terminal cursor from disappearing after breaking change … #373

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions internal/bundler/upgrade.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,16 +240,16 @@ func checkForBreakingChanges(ctx BundleContext, language string, runtime string)
if err := change.Callback(ctx); err != nil {
return err
}
os.Exit(1)
return fmt.Errorf("migration performed, please re-run the command")
} else {
return fmt.Errorf("migration required")
}
} else {
if tui.HasTTY && !ctx.DevMode {
tui.ShowBanner(change.Title, change.Message, true)
os.Exit(1)
return fmt.Errorf("breaking change migration required")
} else {
ctx.Logger.Fatal(change.Message)
return fmt.Errorf("%s", change.Message)
}
}
}
Expand Down
Loading